From: Benny Halevy <bhalevy@primarydata.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
bfields@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/2] nfsd: remove_stid can be incorporated into nfs4_put_delegation
Date: Thu, 07 Nov 2013 12:01:57 -0800 [thread overview]
Message-ID: <527BF1B5.4070508@primarydata.com> (raw)
In-Reply-To: <20131107170204.GA10530@infradead.org>
On 2013-11-07 09:02, Christoph Hellwig wrote:
> On Mon, Nov 04, 2013 at 08:05:08PM -0800, Benny Halevy wrote:
>> On 2013-11-04 14:47, J. Bruce Fields wrote:
>>> On Tue, Oct 15, 2013 at 09:58:00AM +0300, Benny Halevy wrote:
>>>> All calls to nfs4_put_delegation are preceded with remove_stid.
>>>
>>> Whoops, no, we missed the nfs4_put_delegation call in
>>> fs/nfsd/nfs4callback.c.
>>>
>>> Noticed because some pynfs tests triggered idr warnings about freeing
>>> the same id twice.
>>>
>>> I guess I'll revert.
>>
>> OK.
>
> Not sure which patch in your submitted series it was, but with the
> whole series xfstests on NFS 4.1 crashed and burned early on. I'd
> recommend you run xfstests to test any future changes to the state
> handling code in nfsd.
>
Thanks. Will do.
next prev parent reply other threads:[~2013-11-07 20:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <525CE652.3070704@primarydata.com>
2013-10-15 6:56 ` [PATCH 0/2] nfsd: cleanup nfs4_put_delegation Benny Halevy
2013-10-15 6:57 ` [PATCH 1/2] nfsd: nfs4_open_delegation needs to remove_stid rather than unhash_stid Benny Halevy
2013-10-28 19:56 ` J. Bruce Fields
2013-10-15 6:58 ` [PATCH 2/2] nfsd: remove_stid can be incorporated into nfs4_put_delegation Benny Halevy
2013-10-28 20:03 ` J. Bruce Fields
2013-11-04 22:47 ` J. Bruce Fields
2013-11-05 4:05 ` Benny Halevy
2013-11-07 17:02 ` Christoph Hellwig
2013-11-07 17:05 ` J. Bruce Fields
2013-11-07 17:19 ` Christoph Hellwig
2013-11-07 17:47 ` Christoph Hellwig
2013-11-07 20:01 ` Benny Halevy [this message]
2013-11-07 21:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527BF1B5.4070508@primarydata.com \
--to=bhalevy@primarydata.com \
--cc=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).