From: Kinglong Mee <kinglongmee@gmail.com>
To: bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: [PATCH] Do not enter setup_callback_client when finding backchannel failed
Date: Wed, 27 Nov 2013 18:29:22 +0800 [thread overview]
Message-ID: <5295C982.1030904@gmail.com> (raw)
If finding backchannel failed, nfsd should not enter setup_callback_client.
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
fs/nfsd/nfs4callback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 7f05cd1..755d6d6 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -664,7 +664,7 @@ static int setup_callback_client(struct nfs4_client *clp, struct nfs4_cb_conn *c
args.authflavor = clp->cl_cred.cr_flavor;
clp->cl_cb_ident = conn->cb_ident;
} else {
- if (!conn->cb_xprt)
+ if (!conn->cb_xprt || !ses)
return -EINVAL;
clp->cl_cb_conn.cb_xprt = conn->cb_xprt;
clp->cl_cb_session = ses;
@@ -982,7 +982,7 @@ static void nfsd4_process_cb_update(struct nfsd4_callback *cb)
}
spin_unlock(&clp->cl_lock);
- err = setup_callback_client(clp, &conn, ses);
+ err = c ? setup_callback_client(clp, &conn, ses) : -ENOENT;
if (err) {
nfsd4_mark_cb_down(clp, err);
return;
--
1.8.4.2
next reply other threads:[~2013-11-27 10:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 10:29 Kinglong Mee [this message]
2013-12-02 14:59 ` [PATCH] Do not enter setup_callback_client when finding backchannel failed J. Bruce Fields
2013-12-03 2:46 ` Kinglong Mee
2013-12-04 17:10 ` J. Bruce Fields
2013-12-05 2:09 ` Kinglong Mee
2013-12-06 18:00 ` J. Bruce Fields
2013-12-09 1:17 ` Kinglong Mee
2013-12-03 3:40 ` [PATCH v2] " Kinglong Mee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5295C982.1030904@gmail.com \
--to=kinglongmee@gmail.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).