From: "Antti Tönkyrä" <daedalus@pingtimeout.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: Re: Patch for mapping EILSEQ into NFSERR_INVAL
Date: Wed, 04 Dec 2013 13:15:41 +0200 [thread overview]
Message-ID: <529F0EDD.1070403@pingtimeout.net> (raw)
In-Reply-To: <20131204083118.GA30216@infradead.org>
On 2013-12-04 10:31, Christoph Hellwig wrote:
> Please just fix ntfs to do the mapping for you, EILSEQ is not an
> error the VFS or applications expect either.
>
How would you propose the mapping to be done? Are you sure about EILSEQ
not being an error that VFS/applications expect, my userspace tools seem
to handle local filesystem returning EILSEQ just fine?
Moreover I think we really should see why nfs goes into permanent I/O
error state when this is triggered. I don't really mind seeing nfs
unhandled error codes in my kernel log and I/O error on the nfs client
when trying to write badly named files but the fact we cannot recover
from the situation (without closing all handles to the open share) is
alarming.
- Antti
next prev parent reply other threads:[~2013-12-04 11:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 20:21 Patch for mapping EILSEQ into NFSERR_INVAL Antti Tönkyrä
2013-12-02 20:45 ` Trond Myklebust
2013-12-02 20:52 ` Antti Tönkyrä
2013-12-03 20:48 ` Dr Fields James Bruce
2013-12-03 21:22 ` Dr Fields James Bruce
2013-12-04 6:55 ` Antti Tönkyrä
2013-12-04 15:41 ` Dr Fields James Bruce
2013-12-04 20:44 ` Antti Tönkyrä
2013-12-04 21:03 ` Dr Fields James Bruce
2013-12-04 21:08 ` Antti Tönkyrä
2013-12-04 21:22 ` Trond Myklebust
2013-12-04 21:38 ` Dr Fields James Bruce
2013-12-04 22:49 ` Trond Myklebust
2013-12-05 8:39 ` Antti Tönkyrä
2013-12-04 12:33 ` Antti Tönkyrä
2013-12-04 12:40 ` Antti Tönkyrä
2013-12-04 8:31 ` Christoph Hellwig
2013-12-04 11:15 ` Antti Tönkyrä [this message]
2013-12-04 11:19 ` Christoph Hellwig
2013-12-04 11:34 ` Antti Tönkyrä
2013-12-05 19:45 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529F0EDD.1070403@pingtimeout.net \
--to=daedalus@pingtimeout.net \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).