linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] configure.ac: Remove gssglue configuration knobs
@ 2013-12-09 20:05 Steve Dickson
  2013-12-09 20:59 ` Steve Dickson
  0 siblings, 1 reply; 2+ messages in thread
From: Steve Dickson @ 2013-12-09 20:05 UTC (permalink / raw)
  To: Libtirpc-devel Mailing List; +Cc: Linux NFS Mailing list

Its really not a good idea for libtirpc to link with
libgssglue so this patch remove the ability to do that.

Signed-off-by: Steve Dickson <steved@redhat.com>
---
 configure.ac | 23 ++++-------------------
 1 file changed, 4 insertions(+), 19 deletions(-)

diff --git a/configure.ac b/configure.ac
index b9906dc..6b0cf27 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10,26 +10,11 @@ AC_ARG_ENABLE(gssapi,
       [],[enable_gssapi=yes])
 AM_CONDITIONAL(GSS, test x$enable_gssapi = xyes)
 
-AC_ARG_WITH(gssglue,
-		[  --with-gssglue        Use libgssglue],
-		 [case "${enableval}" in
-		  yes) gssglue=true ;;
-		  no)  gssglue=false ;;
-		  *) AC_MSG_ERROR(bad value ${enableval} for --with-gssglue) ;;
-		  esac],
-		[gssglue=false])
-AM_CONDITIONAL(USEGSSGLUE, test x$gssglue = xtrue)
-
 if test x$enable_gssapi = xyes; then
-	if test x$gssglue = xtrue; then
-		PKG_CHECK_MODULES(GSSAPI, libgssglue, [],
-		AC_MSG_ERROR([Unable to locate information required to use libgssglue.]))
-	else
-		GSSAPI_CFLAGS=`krb5-config --cflags gssapi`
-		GSSAPI_LIBS=`krb5-config --libs gssapi`
-		AC_SUBST([GSSAPI_CFLAGS])
-		AC_SUBST([GSSAPI_LIBS])
-	fi
+	GSSAPI_CFLAGS=`krb5-config --cflags gssapi`
+	GSSAPI_LIBS=`krb5-config --libs gssapi`
+	AC_SUBST([GSSAPI_CFLAGS])
+	AC_SUBST([GSSAPI_LIBS])
 fi
 AC_ARG_ENABLE(ipv6,
 	[AC_HELP_STRING([--disable-ipv6], [Disable IPv6 support @<:@default=no@:>@])],
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] configure.ac: Remove gssglue configuration knobs
  2013-12-09 20:05 [PATCH] configure.ac: Remove gssglue configuration knobs Steve Dickson
@ 2013-12-09 20:59 ` Steve Dickson
  0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2013-12-09 20:59 UTC (permalink / raw)
  To: Libtirpc-devel Mailing List; +Cc: Linux NFS Mailing list



On 09/12/13 15:05, Steve Dickson wrote:
> Its really not a good idea for libtirpc to link with
> libgssglue so this patch remove the ability to do that.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
>  configure.ac | 23 ++++-------------------
>  1 file changed, 4 insertions(+), 19 deletions(-)
Committed...

steved.

> 
> diff --git a/configure.ac b/configure.ac
> index b9906dc..6b0cf27 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -10,26 +10,11 @@ AC_ARG_ENABLE(gssapi,
>        [],[enable_gssapi=yes])
>  AM_CONDITIONAL(GSS, test x$enable_gssapi = xyes)
>  
> -AC_ARG_WITH(gssglue,
> -		[  --with-gssglue        Use libgssglue],
> -		 [case "${enableval}" in
> -		  yes) gssglue=true ;;
> -		  no)  gssglue=false ;;
> -		  *) AC_MSG_ERROR(bad value ${enableval} for --with-gssglue) ;;
> -		  esac],
> -		[gssglue=false])
> -AM_CONDITIONAL(USEGSSGLUE, test x$gssglue = xtrue)
> -
>  if test x$enable_gssapi = xyes; then
> -	if test x$gssglue = xtrue; then
> -		PKG_CHECK_MODULES(GSSAPI, libgssglue, [],
> -		AC_MSG_ERROR([Unable to locate information required to use libgssglue.]))
> -	else
> -		GSSAPI_CFLAGS=`krb5-config --cflags gssapi`
> -		GSSAPI_LIBS=`krb5-config --libs gssapi`
> -		AC_SUBST([GSSAPI_CFLAGS])
> -		AC_SUBST([GSSAPI_LIBS])
> -	fi
> +	GSSAPI_CFLAGS=`krb5-config --cflags gssapi`
> +	GSSAPI_LIBS=`krb5-config --libs gssapi`
> +	AC_SUBST([GSSAPI_CFLAGS])
> +	AC_SUBST([GSSAPI_LIBS])
>  fi
>  AC_ARG_ENABLE(ipv6,
>  	[AC_HELP_STRING([--disable-ipv6], [Disable IPv6 support @<:@default=no@:>@])],
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-12-09 20:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-09 20:05 [PATCH] configure.ac: Remove gssglue configuration knobs Steve Dickson
2013-12-09 20:59 ` Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).