From: Benny Halevy <bhalevy@primarydata.com>
To: bfields@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/2] a couple fixes in nfsd4_release_lockowner
Date: Fri, 13 Dec 2013 12:01:26 +0200 [thread overview]
Message-ID: <52AADAF6.40700@primarydata.com> (raw)
Bruce, while working on the state mutex elimination stuff I saw these two issues
in nfsd4_release_lockowner. These patches are untested but I just wanted to quickly get
your take on them.
[PATCH 1/2] nfsd4: break from inner lookup loop in nfsd4_release_lockowner on first match
looks like a potential list corruption risk.
[PATCH 2/2] nfsd4: ignore nfsv4.1 lockowners in nfsd4_release_lockowner
I'm not sure that 100% needed but since we keep both nfsv4.0 and v4.1 owners
hashed on the same lists we don't want a v4.0 operation to accidentally
touch v4.1 state.
Benny
next reply other threads:[~2013-12-13 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 10:01 Benny Halevy [this message]
2013-12-13 10:03 ` [PATCH 1/2] nfsd4: break from inner lookup loop in nfsd4_release_lockowner on first match Benny Halevy
2013-12-13 14:44 ` J. Bruce Fields
2013-12-13 10:03 ` [PATCH 2/2] nfsd4: ignore nfsv4.1 lockowners in nfsd4_release_lockowner Benny Halevy
2013-12-13 14:12 ` Christoph Hellwig
2013-12-19 18:57 ` J. Bruce Fields
2013-12-15 15:50 ` [PATCH 0/2] a couple fixes " Benny Halevy
2013-12-15 15:51 ` [PATCH v2 1/2] nfsd4: break from inner lookup loop in nfsd4_release_lockowner on first match Benny Halevy
2013-12-16 15:43 ` Peng Tao
2013-12-17 19:44 ` Benny Halevy
2013-12-20 2:06 ` Peng Tao
2013-12-19 19:32 ` J. Bruce Fields
2013-12-15 15:51 ` [PATCH v2 2/2] nfsd4: ignore nfsv4.1 lockowners in nfsd4_release_lockowner Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AADAF6.40700@primarydata.com \
--to=bhalevy@primarydata.com \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).