* [PATCH] NFSD: fix a bug which causing nfsd deny CREATE_SESSION
@ 2013-12-23 9:31 Kinglong Mee
2014-01-03 21:34 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Kinglong Mee @ 2013-12-23 9:31 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: linux-nfs
check_forechannel_attrs have get drc memory,
nfsd must put it when check_backchannel_attrs failed.
After many requests with bad back channel attrs,
nfsd will deny any client's CREATE_SESSION forever.
A new test case named CSESS29 for pynfs will send in another mail.
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
fs/nfsd/nfs4state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 105d6fa..4e2c9ba 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1913,7 +1913,7 @@ nfsd4_create_session(struct svc_rqst *rqstp,
return status;
status = check_backchannel_attrs(&cr_ses->back_channel);
if (status)
- return status;
+ goto out_release_drc_mem;
status = nfserr_jukebox;
new = alloc_session(&cr_ses->fore_channel);
if (!new)
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NFSD: fix a bug which causing nfsd deny CREATE_SESSION
2013-12-23 9:31 [PATCH] NFSD: fix a bug which causing nfsd deny CREATE_SESSION Kinglong Mee
@ 2014-01-03 21:34 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2014-01-03 21:34 UTC (permalink / raw)
To: Kinglong Mee; +Cc: linux-nfs
On Mon, Dec 23, 2013 at 05:31:21PM +0800, Kinglong Mee wrote:
> check_forechannel_attrs have get drc memory,
> nfsd must put it when check_backchannel_attrs failed.
>
> After many requests with bad back channel attrs,
> nfsd will deny any client's CREATE_SESSION forever.
Thanks, applying.--b.
>
> A new test case named CSESS29 for pynfs will send in another mail.
>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 105d6fa..4e2c9ba 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1913,7 +1913,7 @@ nfsd4_create_session(struct svc_rqst *rqstp,
> return status;
> status = check_backchannel_attrs(&cr_ses->back_channel);
> if (status)
> - return status;
> + goto out_release_drc_mem;
> status = nfserr_jukebox;
> new = alloc_session(&cr_ses->fore_channel);
> if (!new)
> --
> 1.8.4.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-03 21:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-23 9:31 [PATCH] NFSD: fix a bug which causing nfsd deny CREATE_SESSION Kinglong Mee
2014-01-03 21:34 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).