* [PATCH nfs-utils] tools: use install -m instead of --mode
@ 2014-02-28 21:06 Aaro Koskinen
2014-03-11 18:08 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: Aaro Koskinen @ 2014-02-28 21:06 UTC (permalink / raw)
To: linux-nfs; +Cc: Aaro Koskinen
Use install -m instead of--mode for better compatibility.
E.g. busybox's install doesn't support the long option.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
tools/mountstats/Makefile.am | 2 +-
tools/nfs-iostat/Makefile.am | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/mountstats/Makefile.am b/tools/mountstats/Makefile.am
index ca617a2..c2e9f99 100644
--- a/tools/mountstats/Makefile.am
+++ b/tools/mountstats/Makefile.am
@@ -8,6 +8,6 @@ EXTRA_DIST = $(man8_MANS) $(PYTHON_FILES)
all-local: $(PYTHON_FILES)
install-data-hook:
- $(INSTALL) --mode 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
+ $(INSTALL) -m 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
MAINTAINERCLEANFILES=Makefile.in
diff --git a/tools/nfs-iostat/Makefile.am b/tools/nfs-iostat/Makefile.am
index 30f4054..3ae0f29 100644
--- a/tools/nfs-iostat/Makefile.am
+++ b/tools/nfs-iostat/Makefile.am
@@ -8,6 +8,6 @@ EXTRA_DIST = $(man8_MANS) $(PYTHON_FILES)
all-local: $(PYTHON_FILES)
install-data-hook:
- $(INSTALL) --mode 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
+ $(INSTALL) -m 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
MAINTAINERCLEANFILES=Makefile.in
--
1.8.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH nfs-utils] tools: use install -m instead of --mode
2014-02-28 21:06 [PATCH nfs-utils] tools: use install -m instead of --mode Aaro Koskinen
@ 2014-03-11 18:08 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2014-03-11 18:08 UTC (permalink / raw)
To: Aaro Koskinen, linux-nfs
On 02/28/2014 04:06 PM, Aaro Koskinen wrote:
> Use install -m instead of--mode for better compatibility.
> E.g. busybox's install doesn't support the long option.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Committed...
steved.
> ---
> tools/mountstats/Makefile.am | 2 +-
> tools/nfs-iostat/Makefile.am | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/mountstats/Makefile.am b/tools/mountstats/Makefile.am
> index ca617a2..c2e9f99 100644
> --- a/tools/mountstats/Makefile.am
> +++ b/tools/mountstats/Makefile.am
> @@ -8,6 +8,6 @@ EXTRA_DIST = $(man8_MANS) $(PYTHON_FILES)
> all-local: $(PYTHON_FILES)
>
> install-data-hook:
> - $(INSTALL) --mode 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
> + $(INSTALL) -m 755 mountstats.py $(DESTDIR)$(sbindir)/mountstats
>
> MAINTAINERCLEANFILES=Makefile.in
> diff --git a/tools/nfs-iostat/Makefile.am b/tools/nfs-iostat/Makefile.am
> index 30f4054..3ae0f29 100644
> --- a/tools/nfs-iostat/Makefile.am
> +++ b/tools/nfs-iostat/Makefile.am
> @@ -8,6 +8,6 @@ EXTRA_DIST = $(man8_MANS) $(PYTHON_FILES)
> all-local: $(PYTHON_FILES)
>
> install-data-hook:
> - $(INSTALL) --mode 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
> + $(INSTALL) -m 755 nfs-iostat.py $(DESTDIR)$(sbindir)/nfsiostat
>
> MAINTAINERCLEANFILES=Makefile.in
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-11 19:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-28 21:06 [PATCH nfs-utils] tools: use install -m instead of --mode Aaro Koskinen
2014-03-11 18:08 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).