* [PATCH] NFSv4: Don't retry server trunking discovery on timeouts (v2)
@ 2014-03-07 15:44 Steve Dickson
2014-03-17 14:45 ` Steve Dickson
0 siblings, 1 reply; 3+ messages in thread
From: Steve Dickson @ 2014-03-07 15:44 UTC (permalink / raw)
To: Trond Myklebust; +Cc: Linux NFS Mailing list
To allow background mounts to process into background,
server trunking discovery needs to return the -ETIMEDOUT
error to the mount command instead of endless retrying in
the kernel.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
fs/nfs/nfs4state.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index e1a4721..e0e4d34 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -2083,8 +2083,9 @@ again:
switch (status) {
case 0:
break;
- case -NFS4ERR_DELAY:
case -ETIMEDOUT:
+ break;
+ case -NFS4ERR_DELAY:
case -EAGAIN:
ssleep(1);
case -NFS4ERR_STALE_CLIENTID:
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] NFSv4: Don't retry server trunking discovery on timeouts (v2)
2014-03-07 15:44 [PATCH] NFSv4: Don't retry server trunking discovery on timeouts (v2) Steve Dickson
@ 2014-03-17 14:45 ` Steve Dickson
2014-03-17 14:55 ` Steve Dickson
0 siblings, 1 reply; 3+ messages in thread
From: Steve Dickson @ 2014-03-17 14:45 UTC (permalink / raw)
To: Trond Myklebust; +Cc: Linux NFS Mailing list
Trond,
On 03/07/2014 10:44 AM, Steve Dickson wrote:
> To allow background mounts to process into background,
> server trunking discovery needs to return the -ETIMEDOUT
> error to the mount command instead of endless retrying in
> the kernel.
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
Any chance of reconsidering this patch? Or come up
with a better a way for the kernel to start returning ETIMEOUTS
and ECONNREFUSEDs again?
steved.
> ---
> fs/nfs/nfs4state.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
> index e1a4721..e0e4d34 100644
> --- a/fs/nfs/nfs4state.c
> +++ b/fs/nfs/nfs4state.c
> @@ -2083,8 +2083,9 @@ again:
> switch (status) {
> case 0:
> break;
> - case -NFS4ERR_DELAY:
> case -ETIMEDOUT:
> + break;
> + case -NFS4ERR_DELAY:
> case -EAGAIN:
> ssleep(1);
> case -NFS4ERR_STALE_CLIENTID:
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] NFSv4: Don't retry server trunking discovery on timeouts (v2)
2014-03-17 14:45 ` Steve Dickson
@ 2014-03-17 14:55 ` Steve Dickson
0 siblings, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2014-03-17 14:55 UTC (permalink / raw)
To: Trond Myklebust; +Cc: Linux NFS Mailing list
On 03/17/2014 10:45 AM, Steve Dickson wrote:
> Trond,
>
> On 03/07/2014 10:44 AM, Steve Dickson wrote:
>> To allow background mounts to process into background,
>> server trunking discovery needs to return the -ETIMEDOUT
>> error to the mount command instead of endless retrying in
>> the kernel.
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
> Any chance of reconsidering this patch? Or come up
> with a better a way for the kernel to start returning ETIMEOUTS
> and ECONNREFUSEDs again?
At least in the mount path I should say....
steved.
>
> steved.
>> ---
>> fs/nfs/nfs4state.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
>> index e1a4721..e0e4d34 100644
>> --- a/fs/nfs/nfs4state.c
>> +++ b/fs/nfs/nfs4state.c
>> @@ -2083,8 +2083,9 @@ again:
>> switch (status) {
>> case 0:
>> break;
>> - case -NFS4ERR_DELAY:
>> case -ETIMEDOUT:
>> + break;
>> + case -NFS4ERR_DELAY:
>> case -EAGAIN:
>> ssleep(1);
>> case -NFS4ERR_STALE_CLIENTID:
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-17 14:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-07 15:44 [PATCH] NFSv4: Don't retry server trunking discovery on timeouts (v2) Steve Dickson
2014-03-17 14:45 ` Steve Dickson
2014-03-17 14:55 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).