From: Steve Dickson <SteveD@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFSv4: Don't retry server trunking discovery on timeouts (v2)
Date: Mon, 17 Mar 2014 10:55:45 -0400 [thread overview]
Message-ID: <53270CF1.30007@RedHat.com> (raw)
In-Reply-To: <53270A79.1080306@RedHat.com>
On 03/17/2014 10:45 AM, Steve Dickson wrote:
> Trond,
>
> On 03/07/2014 10:44 AM, Steve Dickson wrote:
>> To allow background mounts to process into background,
>> server trunking discovery needs to return the -ETIMEDOUT
>> error to the mount command instead of endless retrying in
>> the kernel.
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
> Any chance of reconsidering this patch? Or come up
> with a better a way for the kernel to start returning ETIMEOUTS
> and ECONNREFUSEDs again?
At least in the mount path I should say....
steved.
>
> steved.
>> ---
>> fs/nfs/nfs4state.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
>> index e1a4721..e0e4d34 100644
>> --- a/fs/nfs/nfs4state.c
>> +++ b/fs/nfs/nfs4state.c
>> @@ -2083,8 +2083,9 @@ again:
>> switch (status) {
>> case 0:
>> break;
>> - case -NFS4ERR_DELAY:
>> case -ETIMEDOUT:
>> + break;
>> + case -NFS4ERR_DELAY:
>> case -EAGAIN:
>> ssleep(1);
>> case -NFS4ERR_STALE_CLIENTID:
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-03-17 14:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 15:44 [PATCH] NFSv4: Don't retry server trunking discovery on timeouts (v2) Steve Dickson
2014-03-17 14:45 ` Steve Dickson
2014-03-17 14:55 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53270CF1.30007@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).