From: Steve Dickson <SteveD@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFSv4: Memory not being freed on memory allocation failure
Date: Wed, 26 Mar 2014 15:11:18 -0400 [thread overview]
Message-ID: <53332656.2020301@RedHat.com> (raw)
In-Reply-To: <7F3F0CC3-C10F-4C43-9290-6A6C9B1FB53E@primarydata.com>
On 03/26/2014 02:39 PM, Trond Myklebust wrote:
>> Here is what I'm seeing:
>>
>> If rpc_alloc_task() fails, rpc_new_task() returns ERR_PTR(-ENOMEM)
>
> Yes, but before returning ERR_PTR(-ENOMEM), it calls
>
> rpc_release_calldata(setup_data->callback_ops, setup_data->callback_data);
>
> which again calls rpc_ops->rpc_release(calldata)
Ah... I did miss that call... sorry or the noise...
steved.
>
> _________________________________
> Trond Myklebust
> Linux NFS client maintainer, PrimaryData
> trond.myklebust@primarydata.com
>
prev parent reply other threads:[~2014-03-26 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 15:50 [PATCH] NFSv4: Memory not being freed on memory allocation failure Steve Dickson
2014-03-26 17:25 ` Trond Myklebust
2014-03-26 17:48 ` Steve Dickson
2014-03-26 18:39 ` Trond Myklebust
2014-03-26 19:11 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53332656.2020301@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).