linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: "Mkrtchyan, Tigran" <tigran.mkrtchyan@desy.de>
Cc: Daniel Gryniewicz <dang@linuxbox.com>,
	NFS list <linux-nfs@vger.kernel.org>,
	Santosh Pathak <santoshp@panasas.com>,
	Benny Halevy <bhalevy@primarydata.com>,
	open-osd <osd-dev@open-osd.org>,
	Elizabeth Ellenbogen Ziph <elizabeth@linuxbox.com>,
	Sachin bhamare <sachin.bhamare@gmail.com>
Subject: Re: [osd-dev] [PATCH 1/3] ore: (trivial) reformat some code
Date: Sat, 12 Apr 2014 12:26:44 +0300	[thread overview]
Message-ID: <534906D4.1030102@panasas.com> (raw)
In-Reply-To: <53490246.2070000@panasas.com>

On 04/12/2014 12:07 PM, Boaz Harrosh wrote:
>>> -			ret = _ore_add_parity_unit(ios, si, per_dev, cur_len);
>>> +			/* In writes cur_len just means if it's the
>>> +			 * last one. See _ore_add_parity_unit.
>>> +			 */
>>> +			ret = _ore_add_parity_unit(ios, si, per_dev,
>>> +						   ios->sp2d : length : cur_len);
>>
>> Hi Boaz, 
>>
>> did you meant
>>  
>>      ios->sp2d ? length : cur_len);
> 
> my god yes!! why doe it compile? 
> 
> Thanks man
> Boaz
> 

OK Now I know. This same line changes again in the last patch and there
it is correct. I have only always tested the 3 together so it never showed
up. I'll fix it for the next round

Thanks for the catch, you saved me. Beers on me next time
Boaz



  reply	other threads:[~2014-04-12  9:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 10:45 [RFC 0/3] ore: raid6 Boaz Harrosh
2014-04-10 10:49 ` [PATCH 1/3] ore: (trivial) reformat some code Boaz Harrosh
2014-04-11 11:12   ` Mkrtchyan, Tigran
2014-04-12  9:07     ` Boaz Harrosh
2014-04-12  9:26       ` Boaz Harrosh [this message]
2014-04-10 10:53 ` [PATCH 2/3] ore: Remove redundant dev_order(), more cleanups Boaz Harrosh
2014-04-10 11:00 ` [PATCH 3/3] ore: Support for raid 6 Boaz Harrosh
2014-04-10 11:02 ` [osd-dev] [RFC 0/3] ore: raid6 Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=534906D4.1030102@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=bhalevy@primarydata.com \
    --cc=dang@linuxbox.com \
    --cc=elizabeth@linuxbox.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=osd-dev@open-osd.org \
    --cc=sachin.bhamare@gmail.com \
    --cc=santoshp@panasas.com \
    --cc=tigran.mkrtchyan@desy.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).