* [PATCH 1/2] NFSD: Cleanup unused comments and codes in summarize_posix_acl
@ 2014-04-13 12:56 Kinglong Mee
2014-04-13 13:12 ` [PATCH] " Kinglong Mee
0 siblings, 1 reply; 3+ messages in thread
From: Kinglong Mee @ 2014-04-13 12:56 UTC (permalink / raw)
To: J. Bruce Fields, linux-nfs
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
fs/nfsd/nfs4acl.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c
index 6f3f392..de5d66b 100644
--- a/fs/nfsd/nfs4acl.c
+++ b/fs/nfsd/nfs4acl.c
@@ -193,16 +193,9 @@ summarize_posix_acl(struct posix_acl *acl, struct
posix_acl_summary *pas)
{
struct posix_acl_entry *pa, *pe;
- /*
- * Only pas.users and pas.groups need initialization; previous
- * posix_acl_valid() calls ensure that the other fields will be
- * initialized in the following loop. But, just to placate gcc:
- */
memset(pas, 0, sizeof(*pas));
pas->mask = 07;
- pe = acl->a_entries + acl->a_count;
-
FOREACH_ACL_ENTRY(pa, acl, pe) {
switch (pa->e_tag) {
case ACL_USER_OBJ:
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] NFSD: Cleanup unused comments and codes in summarize_posix_acl
2014-04-13 12:56 [PATCH 1/2] NFSD: Cleanup unused comments and codes in summarize_posix_acl Kinglong Mee
@ 2014-04-13 13:12 ` Kinglong Mee
2014-05-08 16:55 ` J. Bruce Fields
0 siblings, 1 reply; 3+ messages in thread
From: Kinglong Mee @ 2014-04-13 13:12 UTC (permalink / raw)
To: J. Bruce Fields, linux-nfs
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
fs/nfsd/nfs4acl.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c
index 6f3f392..de5d66b 100644
--- a/fs/nfsd/nfs4acl.c
+++ b/fs/nfsd/nfs4acl.c
@@ -193,16 +193,9 @@ summarize_posix_acl(struct posix_acl *acl, struct
posix_acl_summary *pas)
{
struct posix_acl_entry *pa, *pe;
- /*
- * Only pas.users and pas.groups need initialization; previous
- * posix_acl_valid() calls ensure that the other fields will be
- * initialized in the following loop. But, just to placate gcc:
- */
memset(pas, 0, sizeof(*pas));
pas->mask = 07;
- pe = acl->a_entries + acl->a_count;
-
FOREACH_ACL_ENTRY(pa, acl, pe) {
switch (pa->e_tag) {
case ACL_USER_OBJ:
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] NFSD: Cleanup unused comments and codes in summarize_posix_acl
2014-04-13 13:12 ` [PATCH] " Kinglong Mee
@ 2014-05-08 16:55 ` J. Bruce Fields
0 siblings, 0 replies; 3+ messages in thread
From: J. Bruce Fields @ 2014-05-08 16:55 UTC (permalink / raw)
To: Kinglong Mee; +Cc: linux-nfs
I'd rather leave the comment there as long as we keep the memset.
I think you're right about the pe initialization, I don't know why
that's there....
--b.
On Sun, Apr 13, 2014 at 09:12:09PM +0800, Kinglong Mee wrote:
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
> fs/nfsd/nfs4acl.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/fs/nfsd/nfs4acl.c b/fs/nfsd/nfs4acl.c
> index 6f3f392..de5d66b 100644
> --- a/fs/nfsd/nfs4acl.c
> +++ b/fs/nfsd/nfs4acl.c
> @@ -193,16 +193,9 @@ summarize_posix_acl(struct posix_acl *acl, struct
> posix_acl_summary *pas)
> {
> struct posix_acl_entry *pa, *pe;
>
> - /*
> - * Only pas.users and pas.groups need initialization; previous
> - * posix_acl_valid() calls ensure that the other fields will be
> - * initialized in the following loop. But, just to placate gcc:
> - */
> memset(pas, 0, sizeof(*pas));
> pas->mask = 07;
>
> - pe = acl->a_entries + acl->a_count;
> -
> FOREACH_ACL_ENTRY(pa, acl, pe) {
> switch (pa->e_tag) {
> case ACL_USER_OBJ:
> --
> 1.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-08 16:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-13 12:56 [PATCH 1/2] NFSD: Cleanup unused comments and codes in summarize_posix_acl Kinglong Mee
2014-04-13 13:12 ` [PATCH] " Kinglong Mee
2014-05-08 16:55 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).