From: Anna Schumaker <schumaker.anna@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Weston Andros Adamson <dros@primarydata.com>,
trond.myklebust@primarydata.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 8/8] pnfs: merge identical functions
Date: Mon, 19 May 2014 13:06:42 -0400 [thread overview]
Message-ID: <537A3A22.4080503@gmail.com> (raw)
In-Reply-To: <20140519165732.GB663@infradead.org>
On 05/19/2014 12:57 PM, Christoph Hellwig wrote:
> On Mon, May 19, 2014 at 12:11:30PM -0400, Anna Schumaker wrote:
>>> I think it should also be mossible to simply call pnfs_put_lseg
>>> from nfs_pgio_header_free. pnfs_put_lseg handles a NULL argument fine,
>>> is stubbed out for the non-pnfs case, and the other callers should never
>>> have it set.
>> Every function in this area is identical to each other :). I'm already working on a patch series that combines these functions (and more!). It also needs more testing before I can submit, but I can update against these patches first to see if this unlocks other cleanups.
> Yes, pnfs.c has lots of duplication of the classic I/O path. I don't
> think we need to rush out your patches, but it would be good to get them
> out in the not too far future.
>
Sure. I won't rush anything, but I'll try not to take too long either.
next prev parent reply other threads:[~2014-05-19 17:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 15:15 [PATCH 0/8] more pgio cleanup Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 1/8] nfs: move nfs_pgio_data and remove nfs_rw_header Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 2/8] nfs: rename members of nfs_pgio_data Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 3/8] nfs: merge nfs_pgio_data into _header Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 4/8] nfs: remove unused writeverf code Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 5/8] nfs: remove pgio_header refcount, related cleanup Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 6/8] pnfs: clean up *_resend_to_mds Weston Andros Adamson
2014-05-19 15:32 ` Christoph Hellwig
2014-05-19 19:25 ` Anna Schumaker
2014-05-19 19:57 ` Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 7/8] nfs: clean up function decls in nfs_page.h Weston Andros Adamson
2014-05-19 15:29 ` Jim Rees
2014-05-19 16:25 ` Weston Andros Adamson
2014-05-19 16:36 ` Jim Rees
2014-05-19 16:56 ` Weston Andros Adamson
2014-05-19 15:15 ` [PATCH 8/8] pnfs: merge identical functions Weston Andros Adamson
2014-05-19 15:34 ` Christoph Hellwig
2014-05-19 16:11 ` Anna Schumaker
2014-05-19 16:21 ` Weston Andros Adamson
2014-05-19 17:06 ` Anna Schumaker
2014-05-19 16:57 ` Christoph Hellwig
2014-05-19 17:06 ` Anna Schumaker [this message]
2014-05-19 17:11 ` Weston Andros Adamson
2014-05-19 17:44 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537A3A22.4080503@gmail.com \
--to=schumaker.anna@gmail.com \
--cc=dros@primarydata.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).