Linux NFS development
 help / color / mirror / Atom feed
From: Kinglong Mee <kinglongmee@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/5] NFSD: Cleanup unneeded including linux/user_namespace.h
Date: Fri, 23 May 2014 22:20:48 +0800	[thread overview]
Message-ID: <537F5940.7060908@gmail.com> (raw)
In-Reply-To: <20140523141855.GN25423@fieldses.org>


On 5/23/2014 22:18, J. Bruce Fields wrote:
> Thanks, applied all five.
> 
> On Fri, May 23, 2014 at 08:53:05PM +0800, Kinglong Mee wrote:
>> commit 4c1e1b34d5c800ad3ac9a7e2805b0bea70ad2278 using kuid/kgid for
> 
> In future, when referring to another commit, could you also include the
> summary line?  E.g.: Commit 8f6c5ffc8987 ("kernel/groups.c: remove
> return value of set_groups") removed the last use of "ret"....

Got it, i will do that in the future.

thanks,
Kinglong Mee

> 
> --b.
> 
>> ex_anon_uid/ex_anon_gid, user_namespace.h is not needed now, clean it.
>>
>> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
>> ---
>>  fs/nfsd/auth.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/nfsd/auth.c b/fs/nfsd/auth.c
>> index 2645be4..1042325 100644
>> --- a/fs/nfsd/auth.c
>> +++ b/fs/nfsd/auth.c
>> @@ -1,7 +1,6 @@
>>  /* Copyright (C) 1995, 1996 Olaf Kirch <okir@monad.swb.de> */
>>  
>>  #include <linux/sched.h>
>> -#include <linux/user_namespace.h>
>>  #include "nfsd.h"
>>  #include "auth.h"
>>  
>> -- 
>> 1.9.3
>>
> 

      reply	other threads:[~2014-05-23 14:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 12:53 [PATCH 1/5] NFSD: Cleanup unneeded including linux/user_namespace.h Kinglong Mee
2014-05-23 14:18 ` J. Bruce Fields
2014-05-23 14:20   ` Kinglong Mee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=537F5940.7060908@gmail.com \
    --to=kinglongmee@gmail.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox