Re: [PATCH v2] NFS4.1: try to clean sessions after testing

[Kinglong Mee <kinglongmee@gmail.com>]

On 6/13/2014 18:44, Kinglong Mee wrote:
> On 6/12/2014 23:25, J. Bruce Fields wrote:
>> On Thu, Jun 12, 2014 at 09:38:32AM +0800, Kinglong Mee wrote:
>>> On 6/12/2014 07:24, Kinglong Mee wrote:
>>>> On 6/12/2014 05:17, J. Bruce Fields wrote:
>>>>> I tried to apply this, and the ipv6 patch (could we do that for 4.1
>>>>> too?) and the 3 other patches, but:
>>>>
>>>> nfs4.1 has supports IPv6, the patch for nfs4.0 is a back-port from nfs4.1.
>>
>> OK, thanks for explaining.
>>
>>>>
>>>>>
>>>>> 	- there are some conflicts with the latest pynfs (e.g. I already
>>>>> 	  added a few acl tests, apologies)
>>>>> 	- I'm getting failures to write to a read-only fs, apparently
>>>>> 	  one of the tests is trying to write to the export root?  I
>>>>> 	  didn't check which one.
>>>
>>> Can you show me more information about this?
>>
>> [root@pip5 pynfs]# ./nfs4.0/testserver.py f19:/exports/xfs/pynfstest-user --maketree
>> Initialization failed, no tests run.
>> Traceback (most recent call last):
>>   File "./nfs4.0/testserver.py", line 381, in <module>
>>     main()
>>   File "./nfs4.0/testserver.py", line 344, in main
>>     env.init()
>>   File "/root/pynfs/nfs4.0/servertests/environment.py", line 140, in init
>>     self._maketree()
>>   File "/root/pynfs/nfs4.0/servertests/environment.py", line 162, in _maketree
>>     check(res, msg="Trying to create /%s," % '/'.join(path))
>>   File "/root/pynfs/nfs4.0/servertests/environment.py", line 253, in check
>>     raise testmod.FailureException(msg)
>> testmod.FailureException: Trying to create /tmp, should return NFS4_OK, instead got NFS4ERR_ROFS
>>
>> This happens after the ipv6 patch.
>>
>> Note /exports on my server is exported read-only, xfs is a separate writeable
>> filesystem.
> 
> Thanks for your testing.
> I have found this bug in IPv6 path, and will send three new path all I have.

I found you have revert the following two patch in your tree,

"NFS4.1: try to clean sessions after testing" and,
"NFS4.0: Case for linking to bad source path with zero-length"

thanks,
Kinglong Mee