From: Steve Dickson <SteveD@redhat.com>
To: Libtirpc-devel Mailing List <libtirpc-devel@lists.sourceforge.net>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [Libtirpc-devel] [PATCH] xdr_rejected_reply: Don't crash with invalid server rejection
Date: Wed, 18 Jun 2014 16:44:50 -0400 [thread overview]
Message-ID: <53A1FA42.5000000@RedHat.com> (raw)
In-Reply-To: <1401976096-16802-1-git-send-email-steved@redhat.com>
On 06/05/2014 09:48 AM, Steve Dickson wrote:
> It seems legacy servers like to return invalid
> rejection status when a RPC is rejected. This
> should not crash the app then it happens.
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed....
steved.
> ---
> src/rpc_prot.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/rpc_prot.c b/src/rpc_prot.c
> index e562deb..5841e51 100644
> --- a/src/rpc_prot.c
> +++ b/src/rpc_prot.c
> @@ -150,7 +150,6 @@ xdr_rejected_reply(xdrs, rr)
> return (xdr_enum(xdrs, (enum_t *)&(rr->rj_why)));
> }
> /* NOTREACHED */
> - assert(0);
> return (FALSE);
> }
>
>
prev parent reply other threads:[~2014-06-18 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 13:48 [PATCH] xdr_rejected_reply: Don't crash with invalid server rejection Steve Dickson
2014-06-18 20:44 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1FA42.5000000@RedHat.com \
--to=steved@redhat.com \
--cc=libtirpc-devel@lists.sourceforge.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).