Re: mount.nfs libmount support (v2)

[Chuck Lever <chuck.lever@oracle.com>]

On Mar 3, 2011, at 8:43 AM, Karel Zak wrote:

> This is the second version of the mount.nfs with libmount support. The code
> depends on util-linux >= v2.19 (e.g. Fedora 15).
> 
> Chnages:
>  - move nfs_umount_do_umnt() to network.c
>  - use union nfs_sockaddr
>  - add missing GPL address paragraph
>  - use abstract function the storing and retrieval mount options
>  - use "static const" for struct option
>  - use "strncmp() == 0" everywhere
> 
> 
> The locale issue is not fixed. It seems that _() macro from nls.h is used on
> many places in the package, but ENABLE_NLS macro is nowhere defined and 
> setlocale() is not called at all.
> 
> I believe that this issue should be fixed independently on the libmount
> patches.

Thanks for the update.

The overall architecture looks sane to me.  I think we would accelerate adoption by having nfs-utils take this now as an experimental "technology preview" thing, so the new code is widely available in a shared repo.  That would make it easier for people to play with it as libmount becomes available in more distributions.  We can then quickly make any minor adjustments needed.  Steve, thoughts?

-- 
Chuck Lever
chuck[dot]lever[at]oracle[dot]com