From: Boaz Harrosh <boaz@plexistor.com>
To: Christoph Hellwig <hch@lst.de>, Benny Halevy <bhalevy@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: layoutcommit space reservation for the objlayout driver
Date: Mon, 15 Sep 2014 12:05:55 +0300 [thread overview]
Message-ID: <5416ABF3.3040403@plexistor.com> (raw)
In-Reply-To: <20140914164655.GB13467@lst.de>
On 09/14/2014 07:46 PM, Christoph Hellwig wrote:
> Currently the NFS client does not reserved any space for the layoutupdate
> field when encoding a layoutcommit. For the file layout driver which doesn't
> have a layoutupdate that's obviously fine, and for the block layoutdriver
> I just fixed the issue in my series by allowing to split in a set of
> preallocated pages. The objlayout driver still needs this fixed, either
> by convincing Trond to increase the reservatation for the few objlayout
> fields, or by splicing in the pages like the block layout driver does.
>
> Can someone with an objlayout setup take care of this?
>
I do not understand. This used to work just fine. Please point me to
the patch that broke it?
(And since when are we allowed to brake old code?)
It will take me a bit of time to get up to speed. Do you want to attempt
a patch and I'll test it?
Thanks
Boaz
next prev parent reply other threads:[~2014-09-15 9:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 16:46 layoutcommit space reservation for the objlayout driver Christoph Hellwig
2014-09-15 9:05 ` Boaz Harrosh [this message]
2014-09-15 17:12 ` Christoph Hellwig
2014-09-16 8:32 ` Boaz Harrosh
[not found] <1538636805.101.1410805338811.JavaMail.root@thunderbeast.private.linuxbox.com>
2014-09-15 18:22 ` Daniel Gryniewicz
2014-09-15 21:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5416ABF3.3040403@plexistor.com \
--to=boaz@plexistor.com \
--cc=bhalevy@primarydata.com \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).