Re: [PATCH] nfsstat: fix server rpc stats header

[Steve Dickson <SteveD@redhat.com>]

On 10/20/2014 01:12 AM, Marko Myllynen wrote:
> linux/net/sunrpc/stats.c has:
> 
> /*
>  * Get RPC server stats
>  */
> void svc_seq_show(struct seq_file *seq, const struct svc_stat *statp) {
> ...
>         seq_printf(seq,
>                 "rpc %u %u %u %u %u\n",
>                         statp->rpccnt,
>                         statp->rpcbadfmt+statp->rpcbadauth+statp->rpcbadclnt,
>                         statp->rpcbadfmt,
>                         statp->rpcbadauth,
>                         statp->rpcbadclnt);
> ...
> 
> But when /proc/net/rpc/nfsd contains
> 
> rpc 1 2 3 4 5
> 
> nfsstat -sv prints:
> 
> Server rpc stats:
> calls      badcalls   badclnt    badauth    xdrcall
> 1          2          3          4          5
> 
> Change this to match the kernel:
> 
> Server rpc stats:
> calls      badcalls   badfmt     badauth    badclnt
> 1          2          3          4          5
> 
> Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1142842.
> 
> Signed-off-by: Marko Myllynen <myllynen@redhat.com>
Committed.... 

steved.

> ---
>  utils/nfsstat/nfsstat.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
> index 18e4d27..9f481db 100644
> --- a/utils/nfsstat/nfsstat.c
> +++ b/utils/nfsstat/nfsstat.c
> @@ -558,7 +558,7 @@ print_server_stats(int opt_prt)
>  			;
>  		} else {
>  			print_numbers(LABEL_srvrpc
> -				"calls      badcalls   badclnt    badauth    xdrcall\n",
> +				"calls      badcalls   badfmt     badauth    badclnt\n",
>  				srvrpcinfo, 5);
>  			printf("\n");
>  		}
>