From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/9] Start reorganizing fs/nfsd/nfsd.h
Date: Thu, 16 Jul 2026 09:35:57 -0400 [thread overview]
Message-ID: <545008d7262e836c3edd5e67ce8d715e24642e21.camel@kernel.org> (raw)
In-Reply-To: <20260712204554.125308-1-cel@kernel.org>
On Sun, 2026-07-12 at 16:45 -0400, Chuck Lever wrote:
> fs/nfsd/nfsd.h has become a kitchen sink of unrelated declarations
> and definitions, including a broad swathe of headers and other
> detritus in NFSD source files. This organization introduces
> brittleness that makes it difficult to execute changes that cut
> across layers and internal modules that might otherwise be cleanly
> siloed. It also pulls in unused items into each TU, making
> compilation of nfsd.ko needlessly slower and more computationally-
> expensive.
>
> This series begins sorting through this pile to relocate items that
> are obviously better placed in NFS version- or task-specific
> headers.
>
> Chuck Lever (9):
> NFSD: Make "stats.h" self-contained
> NFSD: Explicitly include "stats.h"
> NFSD: include "netns.h"
> NFSD: Remove '#include "nfsd.h"' from fs/nfsd/cache.h
> NFSD: Move the export.h include from nfsd.h to auth.c
> NFSD: Move struct readdir_cd
> NFSD: Relocate nfsd_user_namespace()
> NFSD: Relocate nfsd4_set_netaddr()
> NFSD: Relocate NFSv4 "supported attributes" to new header
>
> fs/nfsd/attr4.h | 162 +++++++++++++++++++++++++++++++++++
> fs/nfsd/auth.c | 19 +++++
> fs/nfsd/auth.h | 6 ++
> fs/nfsd/cache.h | 3 +-
> fs/nfsd/nfs4idmap.c | 1 +
> fs/nfsd/nfs4proc.c | 32 +++++++
> fs/nfsd/nfs4state.c | 1 +
> fs/nfsd/nfs4xdr.c | 2 +
> fs/nfsd/nfscache.c | 2 +
> fs/nfsd/nfsctl.c | 2 +
> fs/nfsd/nfsd.h | 202 +-------------------------------------------
> fs/nfsd/nfsfh.c | 2 +
> fs/nfsd/nfsxdr.c | 2 +
> fs/nfsd/state.h | 3 +
> fs/nfsd/stats.c | 2 +
> fs/nfsd/stats.h | 3 +
> fs/nfsd/trace.h | 1 +
> fs/nfsd/vfs.c | 2 +
> fs/nfsd/vfs.h | 5 +-
> fs/nfsd/xdr.h | 1 +
> fs/nfsd/xdr3.h | 1 +
> fs/nfsd/xdr4.h | 2 +-
> 22 files changed, 253 insertions(+), 203 deletions(-)
> create mode 100644 fs/nfsd/attr4.h
This all looks sane.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2026-07-16 13:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 20:45 [PATCH 0/9] Start reorganizing fs/nfsd/nfsd.h Chuck Lever
2026-07-12 20:45 ` [PATCH 1/9] NFSD: Make "stats.h" self-contained Chuck Lever
2026-07-12 20:45 ` [PATCH 2/9] NFSD: Explicitly include "stats.h" Chuck Lever
2026-07-12 20:45 ` [PATCH 3/9] NFSD: include "netns.h" Chuck Lever
2026-07-12 20:45 ` [PATCH 4/9] NFSD: Remove '#include "nfsd.h"' from fs/nfsd/cache.h Chuck Lever
2026-07-12 20:45 ` [PATCH 5/9] NFSD: Move the export.h include from nfsd.h to auth.c Chuck Lever
2026-07-12 20:45 ` [PATCH 6/9] NFSD: Move struct readdir_cd Chuck Lever
2026-07-12 20:45 ` [PATCH 7/9] NFSD: Relocate nfsd_user_namespace() Chuck Lever
2026-07-12 20:45 ` [PATCH 8/9] NFSD: Relocate nfsd4_set_netaddr() Chuck Lever
2026-07-12 20:45 ` [PATCH 9/9] NFSD: Relocate NFSv4 "supported attributes" to new header Chuck Lever
2026-07-16 13:35 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545008d7262e836c3edd5e67ce8d715e24642e21.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox