From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Dave Chinner <david@fromorbit.com>
Cc: <fstests@vger.kernel.org>, <hch@infradead.org>,
<linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] common: Fixes for testing NFS over IPv6
Date: Thu, 30 Oct 2014 08:42:39 -0400 [thread overview]
Message-ID: <5452323F.5010703@Netapp.com> (raw)
In-Reply-To: <20141029233331.GO16186@dastard>
On 10/29/2014 07:33 PM, Dave Chinner wrote:
> On Wed, Oct 29, 2014 at 03:32:07PM -0400, Anna Schumaker wrote:
>> When testing NFS over IPv6, the user will set a $TEST_DEV of the form
>> [fe80::42]:/export. The use of square brackets surrounding the IPv6
>> address is an accepted convention, but grep and awk think that our IPv6
>> address is actually a regex and tries to evaluate it instead. The
>> result is that xfstests reports our filesystem "is busy or already
>> mounted".
>>
>> This patch fixes the IPv6 problem by telling awk and grep to treat
>> $TEST_DEV as a fixed string rather than a regex.
>>
>> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
>
> Seems sensible, but it needs comments so that when someone copies
> the code they know why it's using these sorts of matches.
Sure. I'll add that in, thanks!
>
> Cheers,
>
> Dave.
>
prev parent reply other threads:[~2014-10-30 12:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 19:32 [PATCH] common: Fixes for testing NFS over IPv6 Anna Schumaker
2014-10-29 23:33 ` Dave Chinner
2014-10-30 12:42 ` Anna Schumaker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5452323F.5010703@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox