Re: [PATCH 2/4] common: add _require_block_device() helper

Christoph Hellwig
2014-10-28T13:24:07Z

On Tue, Oct 28, 2014 at 09:16:09PM +0800, Eryu Guan wrote:
> Add _require_block_device() helper and use it in _require_dm_flakey()
> and generic/076.
>
> _require_dm_flakey() assumes $SCRATCH_DEV is a block device, now it can
> also be a NFS export.
>
> generic/076 does "cat $SCRATCH_DEV" which will fail when testing on NFS.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>