Re: [PATCH 1/2] rpc.svcgssd: Add a configure switch to disable building the daemon

NeilBrown
2014-11-05T19:45:25Z

[-- Attachment #1: Type: text/plain, Size: 2067 bytes --]

On Wed, 05 Nov 2014 11:17:18 -0500 Steve Dickson <SteveD@redhat.com> wrote:

>
>
> On 11/04/2014 09:56 PM, NeilBrown wrote:
> > Hi Steve,
> > I just noticed that this causes an error when I try "./configure".
> > It tries to run a program called "enable_svcgss" with args "=" and "yes",
> > but this fails....
> >
> > A simple fix would leave the code doing nothing if enable_gss = yes, but
> > enable_svcgss = no. Is that what you want?
> No...
>
> >
> > Should it be:
> >
> > if test "$enable_gss" = yes -a "$enable_svcgss" = yes; then
> > SVCGSSD=svcgssd
> >> > + else
> >> > + enable_svcgss=
> >> > + SVCGSSD=
> >> > + fi
> > ??
> >
> > Would you like a patch, or will you just fix it up?
> I got it... thanks!
>
> commit e186d734cb3d7c53ef8038b2f62e5b1825d9fa26
> Author: Steve Dickson <steved@redhat.com>
> Date: Wed Nov 5 11:12:03 2014 -0500
>
> configure: Fixed logic around $enable_gss and $enable_svcgss
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
>
> diff --git a/configure.ac b/configure.ac
> index 59fd14d..377ba2e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -108,10 +108,8 @@ AC_ARG_ENABLE(svcgss,
> [enable building svcgssd for rpcsec_gss server support @<:@default=yes@:>@])],
> enable_svcgss=$enableval,
> enable_svcgss=yes)
> - if test "$enable_gss" = yes; then
> - if "enable_svcgss" = yes; then
> - SVCGSSD=svcgssd
> - fi
> + if test "$enable_gss" = yes -a "enable_svcgss" = yes; then
$
> + SVCGSSD=svcgssd
> else
> enable_svcgss=
> SVCGSSD=

Apart from the missing '$', looks good to me - thanks.

NeilBrown

>
>
> steved.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]