From: Steve Dickson <SteveD@redhat.com>
To: "Timo Teräs" <timo.teras@iki.fi>,
linux-nfs@vger.kernel.org, ncopa@alpinelinux.org
Subject: Re: [PATCH v2 0/5] rework access to /proc/net/rpc
Date: Sun, 07 Dec 2014 10:30:35 -0500 [thread overview]
Message-ID: <5484729B.4070001@RedHat.com> (raw)
In-Reply-To: <1412257321-5855-1-git-send-email-timo.teras@iki.fi>
On 10/02/2014 09:41 AM, Timo Teräs wrote:
> Changes since the first send:
> - split to five separate patches
> - fixed a bug in cache_get_filehandle() that made result parsing not work
> - fixed to check result of write() calls
>
> The review mentioned my patches adding:
> nfssvc.c:71:8: warning: ignoring return value of 'system', declared with attribute warn_unused_result [-Wunused-result]
> nfssvc.c:325:9: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
> but this does not make any sense: I'm only adding one #include there.
> Is that perhaps uncovering some other issues?
>
> I'm not sure if the NFSv3 related issues were caused by the cache_get_filehandle()
> issue or not, so this still needs testing. Another potential cause is that the
> kernel is sending to user land requests longer than RPC_CHAN_BUF_SIZE bytes, but
> that does not seem likely.
>
> Timo Teräs (5):
> Add string.h to source files that need it
> mountd: talk to kernel using file descriptors instead of FILE
> gssd: talk to kernel using file descriptors instead of FILE
> nfsexport: talk to kernel using file descriptors instead of FILE
> nfslib: remove now unused FILE helpers
>
> support/include/exportfs.h | 1 +
> support/include/nfslib.h | 7 -
> support/include/nfsrpc.h | 1 +
> support/nfs/cacheio.c | 111 +------------
> support/nfs/nfsexport.c | 77 +++++----
> utils/gssd/gssd_proc.c | 9 +-
> utils/gssd/svcgssd.h | 2 +-
> utils/gssd/svcgssd_main_loop.c | 9 +-
> utils/gssd/svcgssd_proc.c | 51 +++---
> utils/gssd/write_bytes.h | 1 +
> utils/mountd/cache.c | 343 ++++++++++++++++++++++-------------------
> utils/nfsd/nfssvc.c | 1 +
> 12 files changed, 270 insertions(+), 343 deletions(-)
>
Committed and tested!
steved.
next prev parent reply other threads:[~2014-12-07 15:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 13:41 [PATCH v2 0/5] rework access to /proc/net/rpc Timo Teräs
2014-10-02 13:41 ` [PATCH v2 1/5] Add string.h to source files that need it Timo Teräs
2014-10-02 13:41 ` [PATCH v2 2/5] mountd: talk to kernel using file descriptors instead of FILE Timo Teräs
2014-10-02 13:41 ` [PATCH v2 3/5] gssd: " Timo Teräs
2014-10-02 13:42 ` [PATCH v2 4/5] nfsexport: " Timo Teräs
2014-10-02 13:42 ` [PATCH v2 5/5] nfslib: remove now unused FILE helpers Timo Teräs
2014-12-07 15:30 ` Steve Dickson [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-09 8:16 [PATCH v2 0/5] rework access to /proc/net/rpc David Härdeman
2014-12-09 8:42 ` Timo Teras
2014-12-09 14:01 ` David Härdeman
2014-12-09 16:08 ` Steve Dickson
2014-12-09 20:26 ` David Härdeman
2014-12-09 21:30 ` Steve Dickson
2014-12-10 6:09 ` Timo Teras
2014-12-10 14:13 ` David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5484729B.4070001@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=ncopa@alpinelinux.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox