Linux NFS development
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: "David Härdeman" <david@hardeman.nu>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/3] [RFC] nfs-utils: include headers from srcdir
Date: Mon, 08 Dec 2014 13:04:28 -0500	[thread overview]
Message-ID: <5485E82C.7030809@RedHat.com> (raw)
In-Reply-To: <20141202124004.13015.5604.stgit@zeus.muc.hardeman.nu>



On 12/02/2014 07:40 AM, David Härdeman wrote:
> Some of the headers in ./support/include get generated as part of the
> build process (and end up in the build dir hierarchy) and some are
> not (so they stay in the srcdir hierarchy).
> 
> That means the build breaks when using a separate build dir. I'm not sure
> what the best way to make sure that -I$(top_srcdir)/support/include is
> defined everywhere is. Consider this a basis for discussion rather than
> a real patch. Someone with more autoconf-fu can surely come up with a better
> solution.
This one I didn't commit because it caused -I../../support/include to 
defined twice. That path gets define ing  Makefile.in file in the 
DEFAULT_INCLUDES macro. 

steved.

> ---
>  configure.ac |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index e3af723..5d0ab2b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -479,6 +479,9 @@ my_am_cflags="-Wall -Wextra -Wstrict-prototypes $ARCHFLAGS -pipe"
>  
>  AC_SUBST([AM_CFLAGS], ["$my_am_cflags"])
>  
> +AM_CPPFLAGS="$AM_CPPFLAGS -I\$(top_srcdir)/support/include"
> +AC_SUBST([AM_CPPFLAGS])
> +
>  # Make sure that $ACLOCAL_FLAGS are used during a rebuild
>  AC_SUBST([ACLOCAL_AMFLAGS], ["-I $ac_macro_dir \$(ACLOCAL_FLAGS)"])
>  
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2014-12-08 18:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 12:39 [PATCH 0/3] nfs-utils build fixes David Härdeman
2014-12-02 12:39 ` [PATCH 1/3] nfs-utils: fix gssd build flags David Härdeman
2014-12-08 17:33   ` Steve Dickson
2014-12-02 12:39 ` [PATCH 2/3] [RFC] nfs-utils: change internal rpcgen to support separate builddir David Härdeman
2014-12-08 17:36   ` Steve Dickson
2014-12-02 12:40 ` [PATCH 3/3] [RFC] nfs-utils: include headers from srcdir David Härdeman
2014-12-08 18:04   ` Steve Dickson [this message]
2014-12-08 20:45     ` David Härdeman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5485E82C.7030809@RedHat.com \
    --to=steved@redhat.com \
    --cc=david@hardeman.nu \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox