From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 295668614E for ; Wed, 15 Jan 2025 14:56:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736953007; cv=none; b=HXVBvl0xkniW4IuWbLwb2L8s71D3soTbH3VSaQxsiq6pQC7RWF/0wtpWUEltPW3shDuZMdc7A/gG9k52iprbmGeqbTXWp93ZR3bjM57sderxxGCIrodG1sLvY9a8QVcplbdTRxREW69XMZQgWjSd6o3AJkGOdoC8t/AonvXRhfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736953007; c=relaxed/simple; bh=ft6VxV/ibcZtOWH+Aoz+fqB3aX/WiuYjYo+VseXixr8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=IfvZ9S/PilSHGWCBLij+VoGT0s2WGtDTE3uh2ywY/7thWtupxqWBI7yrG7Y8AR2PlCFsuhmytsMn2yzgZh0VNQK+y3AmZRV+QK7Kg43IQdA0cZuB/id4o0dQ+6KerweMyha3+ZQFoKPCmu24zH/mEKHg/TGhlyvZdWujqBit/SI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OsVB6b3O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OsVB6b3O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A3D9C4CED1; Wed, 15 Jan 2025 14:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736953006; bh=ft6VxV/ibcZtOWH+Aoz+fqB3aX/WiuYjYo+VseXixr8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=OsVB6b3OZcdKwDx2JkA1dSZLxUqoCms2t4vZ6MIEYq2R6hNAGIlbpHwC11I/jAyZ4 FUh6pClICCj4/5eg4L7Kh/gHgvQqb6STgqgjjTdiEkilfjuC5wyWcrkI6HEQOblq4r KeiCDnC3rFIwky7Ebj2ODK9fuY4732gt/Nps55bGUTbzuUQN7DvQVRYB01yL7Qgijo f5ud2WDBUPVhmhbaXLtRTanw4HxXj9nZfy+4ksDiQmrCtM03vvP6wM6cQGGRzlIXxL jYduk3qNmywzbQgAzEofj3Pt53pHgNhEuzKu1fzVGBS83WLL0F4VWekagDNL8qlIGt HmfrfcptJ7ogA== Message-ID: <5487afbab2acfe396e1ccc8ba3dfd1256fa00c7b.camel@kernel.org> Subject: Re: [PATCH v2 0/3] nfsdctl: add support for new lockd configuration interface From: Jeff Layton To: Scott Mayhew Cc: Steve Dickson , Yongcheng Yang , linux-nfs@vger.kernel.org Date: Wed, 15 Jan 2025 09:56:45 -0500 In-Reply-To: References: <20250110-lockd-nl-v2-0-e3abe78cc7fb@kernel.org> <659d6f0153daf83ebfcad8d7bdb80adb6aa319b5.camel@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.2 (3.54.2-1.fc41) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-01-15 at 09:44 -0500, Scott Mayhew wrote: > On Tue, 14 Jan 2025, Jeff Layton wrote: >=20 > > On Tue, 2025-01-14 at 16:09 -0500, Scott Mayhew wrote: > > > On Fri, 10 Jan 2025, Jeff Layton wrote: > > >=20 > > > > v2 is just a small update to fix the problems that Scott spotted. > > > >=20 > > > > This patch series adds support for the new lockd configuration inte= rface > > > > that should fix this RH bug: > > > >=20 > > > > https://issues.redhat.com/browse/RHEL-71698 > > > >=20 > > > > There are some other improvements here too, notably a switch to xlo= g. > > > > Only lightly tested, but seems to do the right thing. > > > >=20 > > > > Port handling with lockd still needs more work. Currently that is > > > > usually configured by rpc.statd. I think we need to convert it to > > > > use netlink to configure the ports as well, when it's able. > > > >=20 > > > > Signed-off-by: Jeff Layton > > >=20 > > > I think the read_nfsd_conf call should be moved out of autostart_func > > > and into main (right before the command-line options are parsed). Ri= ght > > > now if you enable debugging in nfs.conf, you get the "configuring > > > listeners" and "nfsdctl exiting" messages, but not the "nfsdctl start= ed" > > > message. It's not a big deal though and could be done if additional > > > debug logging is added in the future. > > >=20 > >=20 > > That sounds good. We can do that in a separate patch. > >=20 > > > Reviewed-by: Scott Mayhew > >=20 > > Thanks! >=20 > Hey, Jeff. I was testing this against a kernel without the lockd > netlink patch, and I get this: >=20 > Jan 15 09:39:16 systemd[1]: Starting nfs-server.service - NFS server and = services... > Jan 15 09:39:17 sh[1603]: nfsdctl: nfsdctl started > Jan 15 09:39:17 sh[1603]: nfsdctl: nfsd not found > Jan 15 09:39:17 sh[1603]: nfsdctl: lockd configuration failure > Jan 15 09:39:17 sh[1603]: nfsdctl: nfsdctl exiting > Jan 15 09:39:17 sh[1601]: rpc.nfsd: knfsd is currently down > Jan 15 09:39:17 sh[1601]: rpc.nfsd: Writing version string to kernel: -2 = +3 +4 +4.1 +4.2 > Jan 15 09:39:17 sh[1601]: rpc.nfsd: Created AF_INET TCP socket. > Jan 15 09:39:17 sh[1601]: rpc.nfsd: Created AF_INET6 TCP socket. >=20 > Do we really want it falling back to rpc.nfsd if it can't configure > lockd? Maybe it should emit a warning instead? >=20 I thought about that, and I think it's better to error out here. Falling back to rpc.nfsd is harmless, and only people who are trying to set the grace period or lockd ports will ever hit this. lockd configuration is a no-op if none of those settings are set. > At the very least, NFSD_FAMILY_NAME should no longer be hard-coded in > that "not found" error message in netlink_msg_alloc(). >=20 Yeah, that would be good to fix. >=20 > >=20 > > > > --- > > > > Changes in v2: > > > > - properly regenerate manpages > > > > - fix up bogus merge conflict > > > > - add D_GENERAL xlog messages when nfsdctl starts and exits > > > > - Link to v1: https://lore.kernel.org/r/20250109-lockd-nl-v1-0-1085= 48ab0b6b@kernel.org > > > >=20 > > > > --- > > > > Jeff Layton (3): > > > > nfsdctl: convert to xlog() > > > > nfsdctl: fix the --version option > > > > nfsdctl: add necessary bits to configure lockd > > > >=20 > > > > configure.ac | 4 + > > > > utils/nfsdctl/lockd_netlink.h | 29 ++++ > > > > utils/nfsdctl/nfsdctl.8 | 15 +- > > > > utils/nfsdctl/nfsdctl.adoc | 8 + > > > > utils/nfsdctl/nfsdctl.c | 331 ++++++++++++++++++++++++++++++= ++++-------- > > > > 5 files changed, 321 insertions(+), 66 deletions(-) > > > > --- > > > > base-commit: 65f4cc3a6ce1472ee4092c4bbf4b19beb0a8217b > > > > change-id: 20250109-lockd-nl-6272fa9e8a5d > > > >=20 > > > > Best regards, > > > > --=20 > > > > Jeff Layton > > > >=20 > > >=20 > >=20 > > --=20 > > Jeff Layton > >=20 >=20 --=20 Jeff Layton