Linux NFS development
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH nfs-utils] configure: use pkg-config to find libtirpc
Date: Mon, 05 Jan 2015 08:14:50 -0500	[thread overview]
Message-ID: <54AA8E4A.6060705@RedHat.com> (raw)
In-Reply-To: <1416755357-12228-1-git-send-email-yann.morin.1998@free.fr>

Hello,

On 11/23/2014 10:09 AM, Yann E. MORIN wrote:
> Currently, we use a custom function to find libtirpc's headers and
> libraries. This works fine for shared linking.
> 
> But for static linking, this forgets to link with -lpthread, which is
> required by libtirpc.
> 
> A recent patch was sent to libtirpc to add that missing -lpthread in its
> Libs.private section of its .pc file. Thus, pkg-config will soon be able
> to return the appropriate libraries.
> 
> So, use pkg-config to find libtirpc.
> 
> And for older libtirpc versions, there is no change in behaviour: we're
> still missing the -lpthread. But once libtirpc has been fixed, we'll
> automatically get that missing library for free! :-)
> 
> Remove the --with-libirpc flag as it is no longer needed: pkg-config
> will provide us with the -I and -L flags, now.
It turns out that using pkg-config break builds on legacy OSs which
is something I don't want to do. I think it's important to at least 
try to maintain legacy builds so I'm looking to revert this patch. 

So if I revert this patch, what will break in your world? 

steved.

  reply	other threads:[~2015-01-05 13:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-23 15:09 [PATCH nfs-utils] configure: use pkg-config to find libtirpc Yann E. MORIN
2015-01-05 13:14 ` Steve Dickson [this message]
2015-01-05 18:23   ` Yann E. MORIN
2015-01-06 18:45     ` Steve Dickson
2015-01-06 19:05       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AA8E4A.6060705@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox