From: Steve Dickson <SteveD@redhat.com>
To: Chris Mayo <aklhfex@gmail.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] statd: Fix test for foreground mode
Date: Sun, 01 Feb 2015 12:49:44 -0500 [thread overview]
Message-ID: <54CE6738.3090100@RedHat.com> (raw)
In-Reply-To: <54CE322D.50402@gmail.com>
On 02/01/2015 09:03 AM, Chris Mayo wrote:
> daemon_init parameter has the opposite sense to code removed in commit 7addf9d
>
> Signed-off-by: Chris Mayo <aklhfex@gmail.com>
> ---
> utils/statd/statd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Committed...
Hmm.. I didn't see this because I did all my testing with
systemd starting/stopping the daemons... I looks like
I'm going to have to rejigger my tests a bit...
What distros/worlds don't systemd? I'll try to bring up
a VM to do some testing in those worlds...
steved.
>
> diff --git a/utils/statd/statd.c b/utils/statd/statd.c
> index 60ce6d1..6ff28f4 100644
> --- a/utils/statd/statd.c
> +++ b/utils/statd/statd.c
> @@ -393,7 +393,7 @@ int main (int argc, char **argv)
> simulator (--argc, ++argv); /* simulator() does exit() */
> #endif
>
> - daemon_init(!(run_mode & MODE_NODAEMON));
> + daemon_init(run_mode & MODE_NODAEMON);
>
> if (run_mode & MODE_LOG_STDERR) {
> xlog_syslog(0);
>
prev parent reply other threads:[~2015-02-01 17:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-01 14:03 [PATCH] statd: Fix test for foreground mode Chris Mayo
2015-02-01 17:49 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CE6738.3090100@RedHat.com \
--to=steved@redhat.com \
--cc=aklhfex@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox