From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <Trond.Myklebust@primarydata.com>, <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 1/6] NFS: Add READ_PLUS support for data segments
Date: Thu, 5 Feb 2015 11:06:34 -0500 [thread overview]
Message-ID: <54D3950A.5050906@Netapp.com> (raw)
In-Reply-To: <20150205141007.GA4522@infradead.org>
On 02/05/2015 09:10 AM, Christoph Hellwig wrote:
> On Wed, Jan 28, 2015 at 03:43:45PM -0500, Anna Schumaker wrote:
>> + if (type == NFS4_CONTENT_DATA)
>> + status = decode_read_plus_data(xdr, res);
>> + else
>> + status = -ENOTSUPP;
>> +
>> + if (segments > 1)
>> + res->eof = 0;
>
> Given that the server can return any amount of data and hole
> segments it doesn't make any sense to separate this patch from patches 4
> and 6.
>
I had them split up to make development easier, but I can squash them together if that would make more sense.
next prev parent reply other threads:[~2015-02-05 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 20:43 [PATCH v2 0/6] NFS: Add READ_PLUS support Anna Schumaker
2015-01-28 20:43 ` [PATCH v2 1/6] NFS: Add READ_PLUS support for data segments Anna Schumaker
2015-02-05 14:10 ` Christoph Hellwig
2015-02-05 16:06 ` Anna Schumaker [this message]
2015-01-28 20:43 ` [PATCH v2 2/6] SUNRPC: Split out a function for setting current page Anna Schumaker
2015-01-28 20:43 ` [PATCH v2 3/6] SUNRPC: Add the ability to expand holes in data pages Anna Schumaker
2015-01-28 20:43 ` [PATCH v2 4/6] NFS: Add READ_PLUS support for hole segments Anna Schumaker
2015-01-28 20:43 ` [PATCH v2 5/6] SUNRPC: Add the ability to shift data to a specific offset Anna Schumaker
2015-01-28 20:43 ` [PATCH v2 6/6] NFS: Add support for decoding multiple segments Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D3950A.5050906@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=Trond.Myklebust@primarydata.com \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox