* [PATCH] NFSv4: Return delegations synchronously in evict_inode
@ 2015-03-27 16:52 Trond Myklebust
2015-03-28 13:50 ` Kinglong Mee
0 siblings, 1 reply; 2+ messages in thread
From: Trond Myklebust @ 2015-03-27 16:52 UTC (permalink / raw)
To: Kinglong Mee; +Cc: linux-nfs
Kinglong Mee reports that asynchronous delegations are being killed
by the call to rpc_shutdown_client() when unmounting. This can lead
to state leakage on the server until the client lease expires.
Reported-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
---
fs/nfs/delegation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c
index a6ad68865880..08c624448750 100644
--- a/fs/nfs/delegation.c
+++ b/fs/nfs/delegation.c
@@ -514,7 +514,7 @@ void nfs_inode_return_delegation_noreclaim(struct inode *inode)
delegation = nfs_inode_detach_delegation(inode);
if (delegation != NULL)
- nfs_do_return_delegation(inode, delegation, 0);
+ nfs_do_return_delegation(inode, delegation, 1);
}
/**
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NFSv4: Return delegations synchronously in evict_inode
2015-03-27 16:52 [PATCH] NFSv4: Return delegations synchronously in evict_inode Trond Myklebust
@ 2015-03-28 13:50 ` Kinglong Mee
0 siblings, 0 replies; 2+ messages in thread
From: Kinglong Mee @ 2015-03-28 13:50 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-nfs
On 2015/3/28 0:52, Trond Myklebust wrote:
> Kinglong Mee reports that asynchronous delegations are being killed
> by the call to rpc_shutdown_client() when unmounting. This can lead
> to state leakage on the server until the client lease expires.
>
> Reported-by: Kinglong Mee <kinglongmee@gmail.com>
> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
With this patch, client can return delegation, destroy session and
client id correctly. I'd like it.
Tested-by: Kinglong Mee <kinglongmee@gmail.com>
thanks,
Kinglong Mee
> ---
> fs/nfs/delegation.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c
> index a6ad68865880..08c624448750 100644
> --- a/fs/nfs/delegation.c
> +++ b/fs/nfs/delegation.c
> @@ -514,7 +514,7 @@ void nfs_inode_return_delegation_noreclaim(struct inode *inode)
>
> delegation = nfs_inode_detach_delegation(inode);
> if (delegation != NULL)
> - nfs_do_return_delegation(inode, delegation, 0);
> + nfs_do_return_delegation(inode, delegation, 1);
> }
>
> /**
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-28 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-27 16:52 [PATCH] NFSv4: Return delegations synchronously in evict_inode Trond Myklebust
2015-03-28 13:50 ` Kinglong Mee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).