linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Wang <yun.wang@profitbricks.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: "ira.weiny" <ira.weiny@intel.com>,
	Roland Dreier <roland@kernel.org>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Trond Myklebust <trond.myklebust@primarydata.com>,
	"David S. Miller" <davem@davemloft.net>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Moni Shoua <monis@mellanox.com>,
	PJ Waskiewicz <pj.waskiewicz@solidfire.com>,
	Tatyana Nikolova <Tatyana.E.Nikolova@intel.com>,
	Yan Burman <yanb@mellanox.com>,
	Jack Morgenstein <jackm@dev.mellanox.co.il>,
	Bart Van Assche <bvanassche@acm.org>,
	Yann Droneaud <ydroneaud@opteya.com>,
	Colin Ian King <colin.king@canonical.com>,
	Majd Dibbiny <majd@mellanox.com>, Jiri Kosina <jkosina@suse.cz>,
	Matan Barak <matanb@mellanox.com>,
	Alex Estrin <alex.estrin@intel.com>,
	Doug Ledford <dledford@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	Erez Shitrit <erezsh@mellanox.com>,
	Sagi Grimberg <sagig@mellanox.com>,
	Haggai Eran <haggaie@mellanox.com>,
	Shachar Raindel <raindel@mellanox.com>,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Steve Wise <swise@opengridcomputing.com>, Tom Tucker <tom@ogc.us>,
	Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check
Date: Tue, 31 Mar 2015 09:39:16 +0200	[thread overview]
Message-ID: <551A4F24.6090405@profitbricks.com> (raw)
In-Reply-To: <20150330223528.GB27728@obsidianresearch.com>

On 03/31/2015 12:35 AM, Jason Gunthorpe wrote:
> On Mon, Mar 30, 2015 at 05:10:12PM +0200, Michael Wang wrote:
>> I found that actually we don't have to touch this one which
>> only used by HW driver currently.
> I'm having a hard time understanding this, the code in question was in
>
> net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
>
> Which is the NFS ULP, not a device driver.

I'm not familiar with this part too :-P but yes, it looks like an ulp
to support NFS.

Actually I'm thinking about Doug's idea to use rdma_transport_is_XX()
instead of the current basic helper, thus may be use rdma_transport_is_iwarp()
in here could be better, since it's actually a feature of iwarp tech
that RDMA Read only support one scatter-gather entry.

But I need more investigation on that idea, there are some part
especially inside device driver I'm not very clear, things could be more
easier if the semantic there is compatible with Doug's proposal ;-)

Regards,
Michael Wang

>
> Regards,
> Jason


  reply	other threads:[~2015-03-31  7:39 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 15:39 [RFC PATCH 00/11] IB/Verbs: IB Management Helpers Michael Wang
2015-03-27 15:40 ` [PATCH 01/11] IB/Verbs: Use helpers to check transport and link layer Michael Wang
2015-03-30 15:56   ` Doug Ledford
2015-03-30 16:14     ` Michael Wang
2015-03-30 16:22       ` Doug Ledford
2015-03-30 17:04         ` Michael Wang
2015-03-27 15:42 ` [RFC PATCH 02/11] IB/Verbs: Use management helper tech_iboe() for iboe-check Michael Wang
2015-03-30 16:17   ` Doug Ledford
2015-03-30 16:23     ` Michael Wang
2015-03-27 15:43 ` [RFC PATCH 03/11] IB/Verbs: Use management helper has_mad() for mad-check Michael Wang
2015-03-27 15:44 ` [RFC PATCH 04/11] IB/Verbs: Use management helper cap_smi() for smi-check Michael Wang
2015-03-27 16:32   ` Jason Gunthorpe
2015-03-27 16:59     ` Yun Wang
2015-03-27 15:45 ` [RFC PATCH 05/11] IB/Verbs: Use management helper has_cm() for cm-check Michael Wang
2015-03-27 15:46 ` [RFC PATCH 06/11] IB/Verbs: Use management helper has_sa() and cap_sa(), for sa-check Michael Wang
2015-03-27 16:47   ` ira.weiny
2015-03-27 17:13     ` Yun Wang
2015-03-27 19:49     ` Doug Ledford
2015-03-30 16:16   ` Doug Ledford
2015-03-30 16:42     ` Michael Wang
2015-03-30 17:02       ` Doug Ledford
2015-03-31 13:22         ` Michael Wang
2015-03-31 23:12         ` Jason Gunthorpe
2015-04-01  0:51           ` ira.weiny
2015-04-01  1:31             ` Jason Gunthorpe
2015-03-27 15:46 ` [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check Michael Wang
2015-03-27 16:28   ` Jason Gunthorpe
2015-03-27 17:05     ` ira.weiny
2015-03-27 17:31       ` Yun Wang
2015-03-27 17:49         ` Jason Gunthorpe
2015-03-27 18:09           ` Yun Wang
2015-03-27 17:47       ` Jason Gunthorpe
2015-03-30  8:30         ` Michael Wang
2015-03-30 22:33           ` Jason Gunthorpe
2015-03-30 16:11   ` Doug Ledford
2015-03-30 16:20     ` Michael Wang
2015-03-30 23:47       ` ira.weiny
2015-03-31  7:25         ` Michael Wang
2015-03-27 15:47 ` [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check Michael Wang
2015-03-27 16:13   ` Jason Gunthorpe
2015-03-27 16:17     ` Michael Wang
2015-03-27 17:16     ` ira.weiny
2015-03-27 17:29       ` Jason Gunthorpe
2015-03-30 15:10         ` Michael Wang
2015-03-30 22:35           ` Jason Gunthorpe
2015-03-31  7:39             ` Michael Wang [this message]
2015-03-31 11:19               ` Tom Talpey
2015-03-31 11:41                 ` Michael Wang
2015-03-31 13:56                   ` Tom Talpey
2015-03-31 13:58                     ` Michael Wang
2015-03-27 17:35       ` Yun Wang
2015-03-30 16:13   ` Doug Ledford
2015-03-30 16:21     ` Michael Wang
2015-03-31 23:20     ` Jason Gunthorpe
2015-03-27 15:48 ` [RFC PATCH 09/11] IB/Verbs: Use management helper has_ipoib() and, cap_ipoib() for ipoib-check Michael Wang
2015-03-27 16:06   ` Jason Gunthorpe
2015-03-27 16:15     ` Michael Wang
2015-03-27 16:38       ` Jason Gunthorpe
2015-03-27 15:49 ` [RFC PATCH 10/11] IB/Verbs: Use management helper cap_ib() for ib-check Michael Wang
2015-03-27 15:49 ` [RFC PATCH 11/11] IB/Verbs: Use management helper cap_eth() for eth-check Michael Wang
2015-04-06 20:22 ` [RFC PATCH 00/11] IB/Verbs: IB Management Helpers ira.weiny
2015-04-07  7:31   ` Michael Wang
2015-04-07 12:48   ` Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551A4F24.6090405@profitbricks.com \
    --to=yun.wang@profitbricks.com \
    --cc=Tatyana.E.Nikolova@intel.com \
    --cc=alex.estrin@intel.com \
    --cc=bfields@fieldses.org \
    --cc=bvanassche@acm.org \
    --cc=chuck.lever@oracle.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=edumazet@google.com \
    --cc=erezsh@mellanox.com \
    --cc=haggaie@mellanox.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=ira.weiny@intel.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=majd@mellanox.com \
    --cc=matanb@mellanox.com \
    --cc=mike.marciniszyn@intel.com \
    --cc=monis@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=pj.waskiewicz@solidfire.com \
    --cc=raindel@mellanox.com \
    --cc=roland@kernel.org \
    --cc=sagig@mellanox.com \
    --cc=sean.hefty@intel.com \
    --cc=swise@opengridcomputing.com \
    --cc=tom@ogc.us \
    --cc=trond.myklebust@primarydata.com \
    --cc=yanb@mellanox.com \
    --cc=ydroneaud@opteya.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).