From: Steve Dickson <SteveD@redhat.com>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
"J. Bruce Fields" <bfields@fieldses.org>
Subject: Re: [PATCH] nfs-utils: add missing comma for exports ent
Date: Mon, 06 Apr 2015 17:14:35 -0400 [thread overview]
Message-ID: <5522F73B.2020909@RedHat.com> (raw)
In-Reply-To: <5521422A.7080005@gmail.com>
On 04/05/2015 10:09 AM, Kinglong Mee wrote:
> When using pnfs with "fsid=0", exportfs prints error as,
>
> # exportfs -a
> exportfs: /var/lib/nfs/etab:1: unknown keyword "no_pnfsfsid=0"
>
> Commit cdd16bef98 ("nfs-utils: add support for the "pnfs" export option")
> miss the comma after "pnfs"/"on_pnfs" operation.
>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Committed...
steved.
> ---
> support/nfs/exports.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/nfs/exports.c b/support/nfs/exports.c
> index 9b325b9..761a046 100644
> --- a/support/nfs/exports.c
> +++ b/support/nfs/exports.c
> @@ -275,7 +275,7 @@ putexportent(struct exportent *ep)
> "no_" : "");
> if (ep->e_flags & NFSEXP_NOREADDIRPLUS)
> fprintf(fp, "nordirplus,");
> - fprintf(fp, "%spnfs", (ep->e_flags & NFSEXP_PNFS)? "" : "no_");
> + fprintf(fp, "%spnfs,", (ep->e_flags & NFSEXP_PNFS)? "" : "no_");
> if (ep->e_flags & NFSEXP_FSID) {
> fprintf(fp, "fsid=%d,", ep->e_fsid);
> }
>
prev parent reply other threads:[~2015-04-06 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 14:09 [PATCH] nfs-utils: add missing comma for exports ent Kinglong Mee
2015-04-06 12:01 ` Christoph Hellwig
2015-04-06 21:14 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5522F73B.2020909@RedHat.com \
--to=steved@redhat.com \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox