* [PATCH] SUNRPC: drop stale setup_socket doc comments
@ 2015-05-05 14:18 Stefan Hajnoczi
2015-05-05 17:10 ` Anna Schumaker
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2015-05-05 14:18 UTC (permalink / raw)
To: linux-nfs
Cc: Anna Schumaker, Trond Myklebust, J. Bruce Fields, Stefan Hajnoczi
xs_local_setup_socket() and xs_tcp_setup_socket() have outdated
arguments listed in the doc comments. Drop arguments that no longer
exist.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
net/sunrpc/xprtsock.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 66891e3..a8d6c6e 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -1886,9 +1886,7 @@ static int xs_local_finish_connecting(struct rpc_xprt *xprt,
/**
* xs_local_setup_socket - create AF_LOCAL socket, connect to a local endpoint
- * @xprt: RPC transport to connect
* @transport: socket transport to connect
- * @create_sock: function to create a socket of the correct type
*/
static int xs_local_setup_socket(struct sock_xprt *transport)
{
@@ -2125,9 +2123,6 @@ out:
/**
* xs_tcp_setup_socket - create a TCP socket and connect to a remote endpoint
- * @xprt: RPC transport to connect
- * @transport: socket transport to connect
- * @create_sock: function to create a socket of the correct type
*
* Invoked by a work queue tasklet.
*/
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] SUNRPC: drop stale setup_socket doc comments
2015-05-05 14:18 [PATCH] SUNRPC: drop stale setup_socket doc comments Stefan Hajnoczi
@ 2015-05-05 17:10 ` Anna Schumaker
2015-05-06 8:26 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Anna Schumaker @ 2015-05-05 17:10 UTC (permalink / raw)
To: Stefan Hajnoczi, linux-nfs
Cc: Anna Schumaker, Trond Myklebust, J. Bruce Fields
Hi Stefan,
On 05/05/2015 10:18 AM, Stefan Hajnoczi wrote:
> xs_local_setup_socket() and xs_tcp_setup_socket() have outdated
> arguments listed in the doc comments. Drop arguments that no longer
> exist.
Can you please fix up xs_local_data_ready(), xs_udp_data_ready(), and xs_tcp_data_ready() while you're at it?
Thanks!
Anna
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> net/sunrpc/xprtsock.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index 66891e3..a8d6c6e 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -1886,9 +1886,7 @@ static int xs_local_finish_connecting(struct rpc_xprt *xprt,
>
> /**
> * xs_local_setup_socket - create AF_LOCAL socket, connect to a local endpoint
> - * @xprt: RPC transport to connect
> * @transport: socket transport to connect
> - * @create_sock: function to create a socket of the correct type
> */
> static int xs_local_setup_socket(struct sock_xprt *transport)
> {
> @@ -2125,9 +2123,6 @@ out:
>
> /**
> * xs_tcp_setup_socket - create a TCP socket and connect to a remote endpoint
> - * @xprt: RPC transport to connect
> - * @transport: socket transport to connect
> - * @create_sock: function to create a socket of the correct type
> *
> * Invoked by a work queue tasklet.
> */
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] SUNRPC: drop stale setup_socket doc comments
2015-05-05 17:10 ` Anna Schumaker
@ 2015-05-06 8:26 ` Stefan Hajnoczi
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2015-05-06 8:26 UTC (permalink / raw)
To: Anna Schumaker; +Cc: linux-nfs, Trond Myklebust, J. Bruce Fields
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
On Tue, May 05, 2015 at 01:10:39PM -0400, Anna Schumaker wrote:
> On 05/05/2015 10:18 AM, Stefan Hajnoczi wrote:
> > xs_local_setup_socket() and xs_tcp_setup_socket() have outdated
> > arguments listed in the doc comments. Drop arguments that no longer
> > exist.
>
> Can you please fix up xs_local_data_ready(), xs_udp_data_ready(), and xs_tcp_data_ready() while you're at it?
Sure, will send a v2.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-06 8:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-05 14:18 [PATCH] SUNRPC: drop stale setup_socket doc comments Stefan Hajnoczi
2015-05-05 17:10 ` Anna Schumaker
2015-05-06 8:26 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).