* [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 @ 2015-04-12 12:04 Kinglong Mee 2015-04-13 12:16 ` Benjamin Coddington 2015-05-07 14:13 ` Steve Dickson 0 siblings, 2 replies; 7+ messages in thread From: Kinglong Mee @ 2015-04-12 12:04 UTC (permalink / raw) To: Steve Dickson; +Cc: bcodding, linux-nfs@vger.kernel.org, kinglongmee When mounting nfs with -ov4, -overs=4 or -onfsvers=4, fail as, # mount -t nfs -ov4 192.168.31.12:/ /testidr/ mount.nfs: access denied by server while mounting 192.168.31.12:/ Fixes: f980298853 "mount.nfs: configurable minor version defaults" Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> --- utils/mount/stropts.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c index df67fac..2ae532e 100644 --- a/utils/mount/stropts.c +++ b/utils/mount/stropts.c @@ -108,12 +108,6 @@ static void nfs_default_version(struct nfsmount_info *mi) return; } - if (mi->version.v_mode == V_GENERAL && - config_default_vers.v_mode == V_DEFAULT) { - mi->version.v_mode = V_SPECIFIC; - return; - } - if (mi->version.v_mode == V_DEFAULT && config_default_vers.v_mode != V_DEFAULT) { mi->version.major = config_default_vers.major; @@ -121,9 +115,9 @@ static void nfs_default_version(struct nfsmount_info *mi) return; } - if (mi->version.v_mode == V_GENERAL && - config_default_vers.v_mode != V_DEFAULT) { - if (mi->version.major == config_default_vers.major) + if (mi->version.v_mode == V_GENERAL) { + if (config_default_vers.v_mode != V_DEFAULT && + mi->version.major == config_default_vers.major) mi->version.minor = config_default_vers.minor; return; } -- 2.3.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 2015-04-12 12:04 [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 Kinglong Mee @ 2015-04-13 12:16 ` Benjamin Coddington 2015-04-13 12:21 ` Kinglong Mee 2015-05-07 14:13 ` Steve Dickson 1 sibling, 1 reply; 7+ messages in thread From: Benjamin Coddington @ 2015-04-13 12:16 UTC (permalink / raw) To: Kinglong Mee; +Cc: Steve Dickson, linux-nfs@vger.kernel.org Hi Kinglong, I can't seem to figure out how to reproduce your problem, and I don't see show this change fixes it. Your mount is falling back to a v3 attempt without this patch? What's set in nfsmount.conf? Ben On Sun, 12 Apr 2015, Kinglong Mee wrote: > When mounting nfs with -ov4, -overs=4 or -onfsvers=4, fail as, > > # mount -t nfs -ov4 192.168.31.12:/ /testidr/ > mount.nfs: access denied by server while mounting 192.168.31.12:/ > > Fixes: f980298853 "mount.nfs: configurable minor version defaults" > Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> > --- > utils/mount/stropts.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c > index df67fac..2ae532e 100644 > --- a/utils/mount/stropts.c > +++ b/utils/mount/stropts.c > @@ -108,12 +108,6 @@ static void nfs_default_version(struct nfsmount_info *mi) > return; > } > > - if (mi->version.v_mode == V_GENERAL && > - config_default_vers.v_mode == V_DEFAULT) { > - mi->version.v_mode = V_SPECIFIC; > - return; > - } > - > if (mi->version.v_mode == V_DEFAULT && > config_default_vers.v_mode != V_DEFAULT) { > mi->version.major = config_default_vers.major; > @@ -121,9 +115,9 @@ static void nfs_default_version(struct nfsmount_info *mi) > return; > } > > - if (mi->version.v_mode == V_GENERAL && > - config_default_vers.v_mode != V_DEFAULT) { > - if (mi->version.major == config_default_vers.major) > + if (mi->version.v_mode == V_GENERAL) { > + if (config_default_vers.v_mode != V_DEFAULT && > + mi->version.major == config_default_vers.major) > mi->version.minor = config_default_vers.minor; > return; > } > -- > 2.3.5 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 2015-04-13 12:16 ` Benjamin Coddington @ 2015-04-13 12:21 ` Kinglong Mee 2015-04-13 12:43 ` Benjamin Coddington 0 siblings, 1 reply; 7+ messages in thread From: Kinglong Mee @ 2015-04-13 12:21 UTC (permalink / raw) To: Benjamin Coddington; +Cc: Steve Dickson, linux-nfs@vger.kernel.org On 4/13/2015 8:16 PM, Benjamin Coddington wrote: > Hi Kinglong, I can't seem to figure out how to reproduce your problem, and > I don't see show this change fixes it. Your mount is falling back to a v3 > attempt without this patch? What's set in nfsmount.conf? Sorry for my missing notes for nfsmount.conf. My nfsmount.conf is default config, besides [ NFSMount_Global_Options ], others line are commented by "#", Defaultvers isn't set as, "# Defaultvers=4" thanks, Kinglong Mee > > Ben > > On Sun, 12 Apr 2015, Kinglong Mee wrote: > >> When mounting nfs with -ov4, -overs=4 or -onfsvers=4, fail as, >> >> # mount -t nfs -ov4 192.168.31.12:/ /testidr/ >> mount.nfs: access denied by server while mounting 192.168.31.12:/ >> >> Fixes: f980298853 "mount.nfs: configurable minor version defaults" >> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> >> --- >> utils/mount/stropts.c | 12 +++--------- >> 1 file changed, 3 insertions(+), 9 deletions(-) >> >> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c >> index df67fac..2ae532e 100644 >> --- a/utils/mount/stropts.c >> +++ b/utils/mount/stropts.c >> @@ -108,12 +108,6 @@ static void nfs_default_version(struct nfsmount_info *mi) >> return; >> } >> >> - if (mi->version.v_mode == V_GENERAL && >> - config_default_vers.v_mode == V_DEFAULT) { >> - mi->version.v_mode = V_SPECIFIC; >> - return; >> - } >> - >> if (mi->version.v_mode == V_DEFAULT && >> config_default_vers.v_mode != V_DEFAULT) { >> mi->version.major = config_default_vers.major; >> @@ -121,9 +115,9 @@ static void nfs_default_version(struct nfsmount_info *mi) >> return; >> } >> >> - if (mi->version.v_mode == V_GENERAL && >> - config_default_vers.v_mode != V_DEFAULT) { >> - if (mi->version.major == config_default_vers.major) >> + if (mi->version.v_mode == V_GENERAL) { >> + if (config_default_vers.v_mode != V_DEFAULT && >> + mi->version.major == config_default_vers.major) >> mi->version.minor = config_default_vers.minor; >> return; >> } >> -- >> 2.3.5 >> >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 2015-04-13 12:21 ` Kinglong Mee @ 2015-04-13 12:43 ` Benjamin Coddington 2015-05-06 13:36 ` Kinglong Mee 0 siblings, 1 reply; 7+ messages in thread From: Benjamin Coddington @ 2015-04-13 12:43 UTC (permalink / raw) To: Kinglong Mee; +Cc: Steve Dickson, linux-nfs@vger.kernel.org On Mon, 13 Apr 2015, Kinglong Mee wrote: > On 4/13/2015 8:16 PM, Benjamin Coddington wrote: > > Hi Kinglong, I can't seem to figure out how to reproduce your problem, and > > I don't see show this change fixes it. Your mount is falling back to a v3 > > attempt without this patch? What's set in nfsmount.conf? > > Sorry for my missing notes for nfsmount.conf. > My nfsmount.conf is default config, > besides [ NFSMount_Global_Options ], others line are commented by "#", > Defaultvers isn't set as, "# Defaultvers=4" > > thanks, > Kinglong Mee Yes, I see the problem now. The version strings were stripped and never added back in the general case. Thank you. This looks right. Reviewed-by: Benjamin Coddington <bcodding@redhat.com> > > On Sun, 12 Apr 2015, Kinglong Mee wrote: > > > >> When mounting nfs with -ov4, -overs=4 or -onfsvers=4, fail as, > >> > >> # mount -t nfs -ov4 192.168.31.12:/ /testidr/ > >> mount.nfs: access denied by server while mounting 192.168.31.12:/ > >> > >> Fixes: f980298853 "mount.nfs: configurable minor version defaults" > >> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> > >> --- > >> utils/mount/stropts.c | 12 +++--------- > >> 1 file changed, 3 insertions(+), 9 deletions(-) > >> > >> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c > >> index df67fac..2ae532e 100644 > >> --- a/utils/mount/stropts.c > >> +++ b/utils/mount/stropts.c > >> @@ -108,12 +108,6 @@ static void nfs_default_version(struct nfsmount_info *mi) > >> return; > >> } > >> > >> - if (mi->version.v_mode == V_GENERAL && > >> - config_default_vers.v_mode == V_DEFAULT) { > >> - mi->version.v_mode = V_SPECIFIC; > >> - return; > >> - } > >> - > >> if (mi->version.v_mode == V_DEFAULT && > >> config_default_vers.v_mode != V_DEFAULT) { > >> mi->version.major = config_default_vers.major; > >> @@ -121,9 +115,9 @@ static void nfs_default_version(struct nfsmount_info *mi) > >> return; > >> } > >> > >> - if (mi->version.v_mode == V_GENERAL && > >> - config_default_vers.v_mode != V_DEFAULT) { > >> - if (mi->version.major == config_default_vers.major) > >> + if (mi->version.v_mode == V_GENERAL) { > >> + if (config_default_vers.v_mode != V_DEFAULT && > >> + mi->version.major == config_default_vers.major) > >> mi->version.minor = config_default_vers.minor; > >> return; > >> } > >> -- > >> 2.3.5 > >> > >> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 2015-04-13 12:43 ` Benjamin Coddington @ 2015-05-06 13:36 ` Kinglong Mee 2015-05-06 18:37 ` Steve Dickson 0 siblings, 1 reply; 7+ messages in thread From: Kinglong Mee @ 2015-05-06 13:36 UTC (permalink / raw) To: Steve Dickson; +Cc: Benjamin Coddington, linux-nfs@vger.kernel.org, kinglongmee On 4/13/2015 8:43 PM, Benjamin Coddington wrote: > On Mon, 13 Apr 2015, Kinglong Mee wrote: > >> On 4/13/2015 8:16 PM, Benjamin Coddington wrote: >>> Hi Kinglong, I can't seem to figure out how to reproduce your problem, and >>> I don't see show this change fixes it. Your mount is falling back to a v3 >>> attempt without this patch? What's set in nfsmount.conf? >> >> Sorry for my missing notes for nfsmount.conf. >> My nfsmount.conf is default config, >> besides [ NFSMount_Global_Options ], others line are commented by "#", >> Defaultvers isn't set as, "# Defaultvers=4" >> >> thanks, >> Kinglong Mee > > Yes, I see the problem now. The version strings were stripped and never > added back in the general case. Thank you. This looks right. > > Reviewed-by: Benjamin Coddington <bcodding@redhat.com> Hello Steve, What's the status of this patch? thanks, Kinglong Mee > >>> On Sun, 12 Apr 2015, Kinglong Mee wrote: >>> >>>> When mounting nfs with -ov4, -overs=4 or -onfsvers=4, fail as, >>>> >>>> # mount -t nfs -ov4 192.168.31.12:/ /testidr/ >>>> mount.nfs: access denied by server while mounting 192.168.31.12:/ >>>> >>>> Fixes: f980298853 "mount.nfs: configurable minor version defaults" >>>> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> >>>> --- >>>> utils/mount/stropts.c | 12 +++--------- >>>> 1 file changed, 3 insertions(+), 9 deletions(-) >>>> >>>> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c >>>> index df67fac..2ae532e 100644 >>>> --- a/utils/mount/stropts.c >>>> +++ b/utils/mount/stropts.c >>>> @@ -108,12 +108,6 @@ static void nfs_default_version(struct nfsmount_info *mi) >>>> return; >>>> } >>>> >>>> - if (mi->version.v_mode == V_GENERAL && >>>> - config_default_vers.v_mode == V_DEFAULT) { >>>> - mi->version.v_mode = V_SPECIFIC; >>>> - return; >>>> - } >>>> - >>>> if (mi->version.v_mode == V_DEFAULT && >>>> config_default_vers.v_mode != V_DEFAULT) { >>>> mi->version.major = config_default_vers.major; >>>> @@ -121,9 +115,9 @@ static void nfs_default_version(struct nfsmount_info *mi) >>>> return; >>>> } >>>> >>>> - if (mi->version.v_mode == V_GENERAL && >>>> - config_default_vers.v_mode != V_DEFAULT) { >>>> - if (mi->version.major == config_default_vers.major) >>>> + if (mi->version.v_mode == V_GENERAL) { >>>> + if (config_default_vers.v_mode != V_DEFAULT && >>>> + mi->version.major == config_default_vers.major) >>>> mi->version.minor = config_default_vers.minor; >>>> return; >>>> } >>>> -- >>>> 2.3.5 >>>> >>>> >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 2015-05-06 13:36 ` Kinglong Mee @ 2015-05-06 18:37 ` Steve Dickson 0 siblings, 0 replies; 7+ messages in thread From: Steve Dickson @ 2015-05-06 18:37 UTC (permalink / raw) To: Kinglong Mee; +Cc: Benjamin Coddington, linux-nfs@vger.kernel.org On 05/06/2015 09:36 AM, Kinglong Mee wrote: > On 4/13/2015 8:43 PM, Benjamin Coddington wrote: >> On Mon, 13 Apr 2015, Kinglong Mee wrote: >> >>> On 4/13/2015 8:16 PM, Benjamin Coddington wrote: >>>> Hi Kinglong, I can't seem to figure out how to reproduce your problem, and >>>> I don't see show this change fixes it. Your mount is falling back to a v3 >>>> attempt without this patch? What's set in nfsmount.conf? >>> >>> Sorry for my missing notes for nfsmount.conf. >>> My nfsmount.conf is default config, >>> besides [ NFSMount_Global_Options ], others line are commented by "#", >>> Defaultvers isn't set as, "# Defaultvers=4" >>> >>> thanks, >>> Kinglong Mee >> >> Yes, I see the problem now. The version strings were stripped and never >> added back in the general case. Thank you. This looks right. >> >> Reviewed-by: Benjamin Coddington <bcodding@redhat.com> > > Hello Steve, > > What's the status of this patch? I'm working on it... ;-) steved. > > thanks, > Kinglong Mee > >> >>>> On Sun, 12 Apr 2015, Kinglong Mee wrote: >>>> >>>>> When mounting nfs with -ov4, -overs=4 or -onfsvers=4, fail as, >>>>> >>>>> # mount -t nfs -ov4 192.168.31.12:/ /testidr/ >>>>> mount.nfs: access denied by server while mounting 192.168.31.12:/ >>>>> >>>>> Fixes: f980298853 "mount.nfs: configurable minor version defaults" >>>>> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> >>>>> --- >>>>> utils/mount/stropts.c | 12 +++--------- >>>>> 1 file changed, 3 insertions(+), 9 deletions(-) >>>>> >>>>> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c >>>>> index df67fac..2ae532e 100644 >>>>> --- a/utils/mount/stropts.c >>>>> +++ b/utils/mount/stropts.c >>>>> @@ -108,12 +108,6 @@ static void nfs_default_version(struct nfsmount_info *mi) >>>>> return; >>>>> } >>>>> >>>>> - if (mi->version.v_mode == V_GENERAL && >>>>> - config_default_vers.v_mode == V_DEFAULT) { >>>>> - mi->version.v_mode = V_SPECIFIC; >>>>> - return; >>>>> - } >>>>> - >>>>> if (mi->version.v_mode == V_DEFAULT && >>>>> config_default_vers.v_mode != V_DEFAULT) { >>>>> mi->version.major = config_default_vers.major; >>>>> @@ -121,9 +115,9 @@ static void nfs_default_version(struct nfsmount_info *mi) >>>>> return; >>>>> } >>>>> >>>>> - if (mi->version.v_mode == V_GENERAL && >>>>> - config_default_vers.v_mode != V_DEFAULT) { >>>>> - if (mi->version.major == config_default_vers.major) >>>>> + if (mi->version.v_mode == V_GENERAL) { >>>>> + if (config_default_vers.v_mode != V_DEFAULT && >>>>> + mi->version.major == config_default_vers.major) >>>>> mi->version.minor = config_default_vers.minor; >>>>> return; >>>>> } >>>>> -- >>>>> 2.3.5 >>>>> >>>>> >>>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 2015-04-12 12:04 [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 Kinglong Mee 2015-04-13 12:16 ` Benjamin Coddington @ 2015-05-07 14:13 ` Steve Dickson 1 sibling, 0 replies; 7+ messages in thread From: Steve Dickson @ 2015-05-07 14:13 UTC (permalink / raw) To: Kinglong Mee; +Cc: bcodding, linux-nfs@vger.kernel.org On 04/12/2015 08:04 AM, Kinglong Mee wrote: > When mounting nfs with -ov4, -overs=4 or -onfsvers=4, fail as, > > # mount -t nfs -ov4 192.168.31.12:/ /testidr/ > mount.nfs: access denied by server while mounting 192.168.31.12:/ > > Fixes: f980298853 "mount.nfs: configurable minor version defaults" > Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> Committed... steved > --- > utils/mount/stropts.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c > index df67fac..2ae532e 100644 > --- a/utils/mount/stropts.c > +++ b/utils/mount/stropts.c > @@ -108,12 +108,6 @@ static void nfs_default_version(struct nfsmount_info *mi) > return; > } > > - if (mi->version.v_mode == V_GENERAL && > - config_default_vers.v_mode == V_DEFAULT) { > - mi->version.v_mode = V_SPECIFIC; > - return; > - } > - > if (mi->version.v_mode == V_DEFAULT && > config_default_vers.v_mode != V_DEFAULT) { > mi->version.major = config_default_vers.major; > @@ -121,9 +115,9 @@ static void nfs_default_version(struct nfsmount_info *mi) > return; > } > > - if (mi->version.v_mode == V_GENERAL && > - config_default_vers.v_mode != V_DEFAULT) { > - if (mi->version.major == config_default_vers.major) > + if (mi->version.v_mode == V_GENERAL) { > + if (config_default_vers.v_mode != V_DEFAULT && > + mi->version.major == config_default_vers.major) > mi->version.minor = config_default_vers.minor; > return; > } > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-05-07 14:13 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-04-12 12:04 [PATCH] mount: make sure mounting nfs with v4,vers=4 and nfsvers=4 Kinglong Mee 2015-04-13 12:16 ` Benjamin Coddington 2015-04-13 12:21 ` Kinglong Mee 2015-04-13 12:43 ` Benjamin Coddington 2015-05-06 13:36 ` Kinglong Mee 2015-05-06 18:37 ` Steve Dickson 2015-05-07 14:13 ` Steve Dickson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).