Re: [PATCH 3/8] nfs: Use remove_proc_subtree() instead remove_proc_entry()

Kinglong Mee
2015-07-01T14:58:13Z

On 7/1/2015 1:20 PM, Al Viro wrote:
> On Wed, Jul 01, 2015 at 11:56:25AM +0800, Kinglong Mee wrote:
>> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
>> ---
>> fs/nfs/client.c | 10 +++-------
>> 1 file changed, 3 insertions(+), 7 deletions(-)
>>
>> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
>> index a13fada..52488ec 100644
>> --- a/fs/nfs/client.c
>> +++ b/fs/nfs/client.c
>> @@ -1447,13 +1447,11 @@ int __init nfs_fs_proc_init(void)
>> /* a file of volumes that we have mounted */
>> p = proc_symlink("volumes", proc_fs_nfs, "../../net/nfsfs/volumes");
>
> Why not make that
> if (!proc_symlink("fs/nfs/volumes", NULL, "../../net/nfsfs/volumes"))
> instead, and kill proc_fs_nfs completely?

That's great. Thank you!

thanks,
Kinglong Mee