From: Steve Dickson <SteveD@redhat.com>
To: ditang chen <ditang.c@gmail.com>
Cc: linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] [patch]libtirpc: check the makefd_xprt return value
Date: Mon, 13 Jul 2015 10:37:09 -0400 [thread overview]
Message-ID: <55A3CD15.6070900@RedHat.com> (raw)
In-Reply-To: <CAHnGgyG-01Ga-U_tvVuwLvQD_d9dei57rHzGXZgtYir4U3V5tg@mail.gmail.com>
On 07/09/2015 09:59 AM, ditang chen wrote:
> xprt may return NULL, so check the return value is necessary.
>
> Signed-off-by: Ditang Chen <ditang.c@gmail.com>
Committed... Thanks!
steved.
> ---
> src/svc_vc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/svc_vc.c b/src/svc_vc.c
> index 9824631..f864951 100644
> --- a/src/svc_vc.c
> +++ b/src/svc_vc.c
> @@ -337,6 +337,8 @@ again:
> */
>
> newxprt = makefd_xprt(sock, r->sendsize, r->recvsize);
> + if (!newxprt)
> + return (FALSE);
>
> if (!__rpc_set_netbuf(&newxprt->xp_rtaddr, &addr, len))
> return (FALSE);
>
prev parent reply other threads:[~2015-07-13 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 13:59 [PATCH] [patch]libtirpc: check the makefd_xprt return value ditang chen
2015-07-13 14:27 ` Chuck Lever
2015-07-13 14:37 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A3CD15.6070900@RedHat.com \
--to=steved@redhat.com \
--cc=ditang.c@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox