linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Calvin Walton <calvin.walton@kepstin.ca>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs-utils: Substitute sbindir in systemd unit files.
Date: Tue, 14 Jul 2015 10:32:12 -0400	[thread overview]
Message-ID: <55A51D6C.2010802@RedHat.com> (raw)
In-Reply-To: <1429638223-13852-1-git-send-email-calvin.walton@kepstin.ca>

Hello Calivn,

I'm finally getting back to take a look at this...

On 04/21/2015 01:43 PM, Calvin Walton wrote:
> The systemd unit files now include the correct full paths to the
> executables when nfs-utils is configured with an alternate value
> for e.g. --prefix or --sbindir
> 
> Signed-off-by: Calvin Walton <calvin.walton@kepstin.ca>
> ---
> 
> Resend of the same patch, but this time generated with -M so the diff
> includes file moves; this should make it a bit easier to review.
I see what your are trying to do... Make the systemd scripts
use @sbindir@ instead of a hard coded '/usr/sbin/' which 
is fine. To do this you are renaming all the systemd 
scripts to .in systemd scripts. 

But what I'm missing is what actually generates the 
systemd scripts with the correct path names?

Since you took out the install-data-hook: rule from
the Makefile.am file, when I do a make install none
of the scripts get installed.... 

steved.

  reply	other threads:[~2015-07-14 14:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 17:40 [PATCH] nfs-utils: Substitute sbindir in systemd unit files Calvin Walton
2015-04-21 17:43 ` Calvin Walton
2015-07-14 14:32   ` Steve Dickson [this message]
2015-07-14 15:22     ` Calvin Walton
2015-07-14 15:36       ` Steve Dickson
2015-11-02 12:53   ` Steve Dickson
2015-11-02 13:23     ` Calvin Walton
2015-05-06 20:28 ` Steve Dickson
2015-05-06 20:39   ` Calvin Walton
2015-05-07 13:36     ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A51D6C.2010802@RedHat.com \
    --to=steved@redhat.com \
    --cc=calvin.walton@kepstin.ca \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).