From: Kinglong Mee <kinglongmee@gmail.com>
To: tigran.mkrtchyan@desy.de, bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, kinglongmee@gmail.com
Subject: Re: [PATCH] pynfs: reduce code duplication
Date: Fri, 17 Jul 2015 07:54:25 +0800 [thread overview]
Message-ID: <55A84431.3000603@gmail.com> (raw)
In-Reply-To: <1437064828-15387-1-git-send-email-tigran.mkrtchyan@desy.de>
On 7/17/2015 00:40, tigran.mkrtchyan@desy.de wrote:
> From: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
>
> the test suite has two methods: check and checklist to
> validate status codes of a compound operation. The both
> methods are identical, except one of them accept a single
> status code and other accepts a list.
>
> Modify 'check' to accept a list as well to reduce code
> duplication.
>
> Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
> ---
> nfs4.1/server41tests/environment.py | 40 ++++++++++++------------------
> nfs4.1/server41tests/st_current_stateid.py | 6 ++---
> nfs4.1/server41tests/st_delegation.py | 6 ++---
> nfs4.1/server41tests/st_destroy_session.py | 2 +-
> nfs4.1/server41tests/st_exchange_id.py | 4 +--
> nfs4.1/server41tests/st_lookup.py | 10 ++++----
> nfs4.1/server41tests/st_open.py | 2 +-
> nfs4.1/server41tests/st_reboot.py | 2 +-
> nfs4.1/server41tests/st_rename.py | 14 +++++------
> nfs4.1/server41tests/st_verify.py | 4 +--
> 10 files changed, 41 insertions(+), 49 deletions(-)
>
Make sense.
I think clean all "checklist" is better.
"checklist" also exist in,
nfs4.1/client41tests/environment.py
nfs4.0/servertests/environment.py
Anyway this one is nice for nfs4.1 server.
thanks,
Kinglong Mee
next prev parent reply other threads:[~2015-07-16 23:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 16:40 [PATCH] pynfs: reduce code duplication tigran.mkrtchyan
2015-07-16 23:54 ` Kinglong Mee [this message]
2015-07-17 14:19 ` Mkrtchyan, Tigran
2015-07-22 19:26 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A84431.3000603@gmail.com \
--to=kinglongmee@gmail.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tigran.mkrtchyan@desy.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox