* [PATCH] rpc.gssd: Replace exit(0) by return in process_krb5_upcall
@ 2015-08-19 19:58 andros
2015-08-24 17:51 ` Steve Dickson
0 siblings, 1 reply; 3+ messages in thread
From: andros @ 2015-08-19 19:58 UTC (permalink / raw)
To: steved; +Cc: linux-nfs, Andy Adamson
From: Andy Adamson <andros@netapp.com>
exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory
rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for
each upcall, ignoring a valid TGT in the kerberos credential cache.
Signed-off-by: Andy Adamson <andros@netapp.com>
---
utils/gssd/gssd_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
index 03afc8b..3fc7bba 100644
--- a/utils/gssd/gssd_proc.c
+++ b/utils/gssd/gssd_proc.c
@@ -684,7 +684,7 @@ out:
AUTH_DESTROY(auth);
if (rpc_clnt)
clnt_destroy(rpc_clnt);
- exit(0);
+ return;
out_return_error:
do_error_downcall(fd, uid, downcall_err);
--
1.9.3 (Apple Git-50)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rpc.gssd: Replace exit(0) by return in process_krb5_upcall
2015-08-19 19:58 [PATCH] rpc.gssd: Replace exit(0) by return in process_krb5_upcall andros
@ 2015-08-24 17:51 ` Steve Dickson
2015-09-08 15:16 ` Steve Dickson
0 siblings, 1 reply; 3+ messages in thread
From: Steve Dickson @ 2015-08-24 17:51 UTC (permalink / raw)
To: andros; +Cc: linux-nfs
On 08/19/2015 03:58 PM, andros@netapp.com wrote:
> From: Andy Adamson <andros@netapp.com>
>
> exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory
> rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for
> each upcall, ignoring a valid TGT in the kerberos credential cache.
>
> Signed-off-by: Andy Adamson <andros@netapp.com>
Committed...
steved.
> ---
> utils/gssd/gssd_proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
> index 03afc8b..3fc7bba 100644
> --- a/utils/gssd/gssd_proc.c
> +++ b/utils/gssd/gssd_proc.c
> @@ -684,7 +684,7 @@ out:
> AUTH_DESTROY(auth);
> if (rpc_clnt)
> clnt_destroy(rpc_clnt);
> - exit(0);
> + return;
>
> out_return_error:
> do_error_downcall(fd, uid, downcall_err);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rpc.gssd: Replace exit(0) by return in process_krb5_upcall
2015-08-24 17:51 ` Steve Dickson
@ 2015-09-08 15:16 ` Steve Dickson
0 siblings, 0 replies; 3+ messages in thread
From: Steve Dickson @ 2015-09-08 15:16 UTC (permalink / raw)
To: andros; +Cc: linux-nfs
On 08/24/2015 01:51 PM, Steve Dickson wrote:
>
>
> On 08/19/2015 03:58 PM, andros@netapp.com wrote:
>> From: Andy Adamson <andros@netapp.com>
>>
>> exit(0) silenty reaps the gssd_k5_kt_princ struct, the in-memory
>> rpc.gssd cache which means that rpc.gssd will get a new TGT and TGS for
>> each upcall, ignoring a valid TGT in the kerberos credential cache.
>>
>> Signed-off-by: Andy Adamson <andros@netapp.com>
> Committed...
This has been reverted due to child processes not exiting on upcalls.
steved.
>
> steved.
>
>> ---
>> utils/gssd/gssd_proc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/utils/gssd/gssd_proc.c b/utils/gssd/gssd_proc.c
>> index 03afc8b..3fc7bba 100644
>> --- a/utils/gssd/gssd_proc.c
>> +++ b/utils/gssd/gssd_proc.c
>> @@ -684,7 +684,7 @@ out:
>> AUTH_DESTROY(auth);
>> if (rpc_clnt)
>> clnt_destroy(rpc_clnt);
>> - exit(0);
>> + return;
>>
>> out_return_error:
>> do_error_downcall(fd, uid, downcall_err);
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-08 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 19:58 [PATCH] rpc.gssd: Replace exit(0) by return in process_krb5_upcall andros
2015-08-24 17:51 ` Steve Dickson
2015-09-08 15:16 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).