linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: "Aurélien Chabot" <aurelien@chabot.fr>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] Install only needed systemd unit file
Date: Tue, 15 Sep 2015 14:26:53 -0400	[thread overview]
Message-ID: <55F862ED.4060900@RedHat.com> (raw)
In-Reply-To: <1437428480-22951-1-git-send-email-aurelien@chabot.fr>



On 07/20/2015 05:41 PM, Aurélien Chabot wrote:
> Signed-off-by: Aurélien Chabot <aurelien@chabot.fr>
> ---
>  systemd/Makefile.am | 22 +++++++++++++++++-----
>  1 file changed, 17 insertions(+), 5 deletions(-)
Committed.... 

Note, I also found an issue with the --with-systemd flag
which was fixed by:

commit 017164521b94018bd143b879b0e858d98cca83e8
Author: Steve Dickson <steved@redhat.com>
Date:   Tue Sep 15 14:16:42 2015 -0400

    configure.ac: with-systemd flag not using default directory
    
    The with-systemd config flag was not using the
    default directory when a directory was not given
    
    Signed-off-by: Steve Dickson <steved@redhat.com>

steved.

> 
> diff --git a/systemd/Makefile.am b/systemd/Makefile.am
> index fbcabb1..0331926 100644
> --- a/systemd/Makefile.am
> +++ b/systemd/Makefile.am
> @@ -5,21 +5,33 @@ MAINTAINERCLEANFILES = Makefile.in
>  unit_files =  \
>      nfs-client.target \
>      \
> -    auth-rpcgss-module.service \
> -    nfs-blkmap.service \
>      nfs-config.service \
> -    nfs-idmapd.service \
>      nfs-mountd.service \
>      nfs-server.service \
>      nfs-utils.service \
> -    rpc-gssd.service \
>      rpc-statd-notify.service \
>      rpc-statd.service \
> -    rpc-svcgssd.service \
>      \
>      proc-fs-nfsd.mount \
>      var-lib-nfs-rpc_pipefs.mount
>  
> +if CONFIG_NFSV4
> +unit_files += \
> +    nfs-idmapd.service
> +endif
> +
> +if CONFIG_NFSV41
> +unit_files += \
> +    nfs-blkmap.service
> +endif
> +
> +if CONFIG_GSS
> +unit_files += \
> +    auth-rpcgss-module.service \
> +    rpc-gssd.service \
> +    rpc-svcgssd.service
> +endif
> +
>  EXTRA_DIST = $(unit_files)
>  
>  unit_dir = /usr/lib/systemd/system
> 

      reply	other threads:[~2015-09-15 18:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 21:41 [PATCH] Install only needed systemd unit file Aurélien Chabot
2015-09-15 18:26 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F862ED.4060900@RedHat.com \
    --to=steved@redhat.com \
    --cc=aurelien@chabot.fr \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).