From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0F6140DFA3; Fri, 24 Apr 2026 00:26:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776990391; cv=none; b=mHzgU5s7smoYfNJntRzvTbFjCzO1KSRZ/PAwuO7YGGdDlgyRzDhHe5RWzUcbsOgIQ3r2j43b7qTQ/9w3ZppeKUwEBnncpoEkHLprEhytVqXTqXxhumLDgTM1fIcgMpkVsx1UFjQdRcxpER++DYAB+yLIgZPW/bXQAFbpcxPkW3M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776990391; c=relaxed/simple; bh=Fr54Lpf556s8S882LYfydAUf8F6fqDeLQtc/HVT0mo4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=KaHoCwD01CP/dllia9no3hu4ml9Ij2R96Z09B9qVqrKPeJYowxf7dYUPFYD1VulI9uJSoEwRe/s/Z9I/ZCWVelkRY+RRu26BbGBQJxD0toId+DpzBLuglxf6k4j5wERgwNnBAc0kxqyS7U7MFrXvGZAGwW5pMeQ9jSWPo2WvCiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MBSzm3X1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MBSzm3X1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7039C2BCAF; Fri, 24 Apr 2026 00:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776990390; bh=Fr54Lpf556s8S882LYfydAUf8F6fqDeLQtc/HVT0mo4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=MBSzm3X1I9cMuiO0j71cM30vjvvDEJOcuSt5uR82kcIVXF3IYETuHM1Fsk39PO/As wHaP9cCgw9IMqlaH3TVMLMhFZaHzfcLfd/rpOoZde/9ud+fYOU20U9AgMkfS1RILTx kz6+0T5qtkAUijQKJo1Au1s6WAqyMFfHMF+PLvxPpwdKBT7suODyaDUKzIfT3bbfYV c8P31c9xDL92A46w8sVEltZhd1FqeHEeBW8AxZtVKR7FNZmtDE71fr4dfGnIiYSdTp KI2mhtKsRp+exNZbejxUxOvuBl7FiI9U0Gmk6qg4GJjjVXZ8bjAvQqK9HieSa7rSij N22jaKkDJ4Img== Message-ID: <55bfc1442ee1a80723520b714fc5f358d11c4c38.camel@kernel.org> Subject: Re: [PATCH RFC] sunrpc: hardcode pool_mode to pernode, remove other modes From: Jeff Layton To: Chuck Lever , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 23 Apr 2026 20:26:26 -0400 In-Reply-To: References: <20260423-sunrpc-pool-mode-v1-1-b7f20e35749b@kernel.org> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2026-04-23 at 12:45 -0400, Chuck Lever wrote: > On Thu, Apr 23, 2026, at 10:39 AM, Jeff Layton wrote: > > The SVC_POOL_AUTO/GLOBAL/PERCPU/PERNODE pool mode selection machinery > > was added when NUMA was new and the right default was unclear. Today, > > pernode is the right choice everywhere: > >=20 > > - On multi-NUMA hosts, it gives one pool per node with proper thread > > affinity and NUMA-local memory allocation. > > - On single-node hosts, pernode degenerates to exactly one pool, > > identical to the old "global" mode -- svc_pool_for_cpu() short- > > circuits when sv_nrpools <=3D 1, no CPU affinity is set, and memory > > is allocated from the single node. > >=20 > > The percpu mode (one pool per CPU) created excessive pools relative to > > the number of threads most deployments run, and was only auto-selected > > in a narrow case (single node, >2 CPUs). > >=20 > > Remove the SVC_POOL_* enum, mode selection heuristic, > > svc_pool_map_init_percpu(), and all mode-based switch statements. > > Simplify pool map functions to always use the pernode path. > >=20 > > The module parameter and netlink interfaces are preserved for backward > > compatibility: > > - Writing "pernode" succeeds; any other value returns -EINVAL > > - Reading always returns "pernode" > > - Writing to the module parameter emits a deprecation notice > >=20 > > Assisted-by: Claude:claude-opus-4-6 > > Signed-off-by: Jeff Layton > > --- > > In hindsight, I wish I had proposed this before adding the pool-mode > > settings to the new nfsd netlink interfaces. > >=20 > > If this is too radical as a single step, we just could switch the > > default to "pernode", add a warning and leave the interfaces alone for > > now. Or maybe do that and go ahead and remove the percpu setting? > >=20 > > Thoughts? >=20 > Generally, I think the end goal of making "per-node" the default > and only setting is correct. My comments below are about how we > get there. >=20 > The main concern is not perturbing any configuration that today > happens to set the module parameter. >=20 > The proposed patch correctly preserves the shape of the user/kernel > interfaces (same module parameter name and perms, same netlink command > and attribute, same exported symbol names and signatures). The concern > is that the accepted input set has narrowed from four strings to one > and the setters reject the legacy three with -EINVAL. For the module > parameter that path runs at module load, so existing modprobe.d configs > written any time in the last ~19 years will cause load-time parameter > errors. Some might categorize that as a regression. > =20 > The commit message documents that non-"pernode" writes now return > -EINVAL. The historically correct approach for this kind of obsoleted > tuning knob is to accept-and-ignore the old values (plus the pr_notice) > rather than hard-fail. >=20 > Or, put another way, the proposed patch implements something slightly > different than true backwards compatibility. Userspace that previously > set pool_mode=3Dglobal/percpu/auto now gets -EINVAL, which technically > speaking is a behavioral narrowing, not "backward compatibility." >=20 > I might go even further and suggest that perhaps for v7.2: >=20 > - Change the behavior of "auto" to be per-node That's already the case if you're on a NUMA box. The problem is that the default is not "auto" but "global". We could change that (easily), but I'd argue that "auto" mode just devolves into "pernode" for two reasons: - "pernode" is functionally identical to "global" when there is only a single NUMA node - "percpu" mode is basically useless If we want to "go slow" on this, then what I'd probably suggest is that we just change the default to "pernode" initially. Single node boxes that have this set to global today should see no real change (functionally identical). Boxes with multiple NUMA nodes that don't set it now, will start using pernode mode, but that's probably a good thing in most cases. > - Add a deprecation warning that is emitted when setting other modes, > but don't warn when the value is specifically the only accepted one. >=20 We probably do still want to warn in that case. Once we remove the option, the module load can fail, so we probably want to discourage people from keeping the setting. > Then wait a few more cycles before removal of percpu and global. >=20 That's fair. We can stage this in slowly. I'm terrible about following up with the later phases of long term deprecation though. Suggestions on how to make sure we don't drop the ball on finishing the change? > Other notes: >=20 > o The existing pernode path assumes every online node has both CPUs and > some memory. nr_online_nodes on some platforms (e.g., certain ARM64, > CXL) counts memoryless or CPU-less nodes; for_each_node_with_cpus() > vs. for_each_online_node() matters here. See > svc_pool_map_init_pernode(). >=20 Good point. We should probably change that too. > o Recommend review of some history on this topic: > https://lore.kernel.org/linux-nfs/f027319a-378d-4b91-a418-c45218fb7a21@= oracle.com/ >=20 Thanks. I'll read up. --=20 Jeff Layton