linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Steve Wise <swise@opengridcomputing.com>,
	<trond.myklebust@primarydata.com>, <bfields@fieldses.org>
Cc: <linux-nfs@vger.kernel.org>, <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers
Date: Mon, 28 Sep 2015 10:45:26 -0400	[thread overview]
Message-ID: <56095286.6030201@Netapp.com> (raw)
In-Reply-To: <56094F16.3040608@opengridcomputing.com>

Hi Steve,

On 09/28/2015 10:30 AM, Steve Wise wrote:
> On 9/21/2015 12:24 PM, Steve Wise wrote:
>> Otherwise a FRMR completion can cause a touch-after-free crash.
>>
>> In xprt_rdma_destroy(), call rpcrdma_buffer_destroy() only after calling
>> rpcrdma_ep_destroy().
>>
>> In rpcrdma_ep_destroy(), disconnect the cm_id first which should flush the
>> qp, then drain the cqs, then destroy the qp, and finally destroy the cqs.
>>
>> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
>> Tested-by: Chuck Lever <chuck.lever@oracle.com>
>> ---
> 
> Hey Trond,  I'm hoping this can make 4.3-rc (and stable if you agree).

This patch looks fine to me.  I'll pass it on to Trond!

I'll save patch 3/3 for the Linux 4.4 merge.

Thanks,
Anna

> 
> Thanks,
> 
> Steve.
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2015-09-28 14:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 17:24 [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers Steve Wise
2015-09-21 17:24 ` [PATCH 2/3] svcrdma: handle rdma read with a non-zero initial page offset Steve Wise
2015-09-28 14:31   ` Steve Wise
2015-09-28 21:04     ` J. Bruce Fields
2015-09-28 21:49       ` Steve Wise
2015-09-29 15:40         ` 'J. Bruce Fields'
2015-09-21 17:24 ` [PATCH 3/3] xprtrdma: don't log warnings for flushed completions Steve Wise
2015-09-28 14:30 ` [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers Steve Wise
2015-09-28 14:45   ` Anna Schumaker [this message]
2015-09-28 14:50     ` Steve Wise
2015-09-28 14:57       ` Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56095286.6030201@Netapp.com \
    --to=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=swise@opengridcomputing.com \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).