From: Rinku Kothiya <rkothiya@redhat.com>
To: Steve Dickson <steved@redhat.com>, linux-nfs@vger.kernel.org
Cc: Mohit Agrawal <moagrawa@redhat.com>
Subject: [nfs-utils PATCH] Set right error after getaddrinfo fails bz 1287468, Please find the same patch attached to this email as well
Date: Tue, 22 Dec 2015 14:39:24 +0530 [thread overview]
Message-ID: <56791344.9050900@redhat.com> (raw)
In-Reply-To: <567782F6.4010306@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1780 bytes --]
From: Rinku Kothiya <rkothiya@redhat.com>
Signed-off-by: Rinku Kothiya <rkothiya@redhat.com>
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>
---
nfs-utils-1.3.0-set-errno.patch | 29 +++++++++++++++++++++++++++++
nfs-utils.spec | 23 ++++++++++++-----------
2 files changed, 41 insertions(+), 11 deletions(-)
create mode 100644 nfs-utils-1.3.0-set-errno.patch
diff --git a/nfs-utils-1.3.0-set-errno.patch b/nfs-utils-1.3.0-set-errno.patch
new file mode 100644
index 0000000..7c9d381
--- /dev/null
+++ b/nfs-utils-1.3.0-set-errno.patch
@@ -0,0 +1,29 @@
+diff -up nfs-utils-1.3.0/support/export/hostname.c.orig nfs-utils-1.3.0/support/export/hostname.c
+--- nfs-utils-1.3.0/support/export/hostname.c.orig 2015-12-08 15:24:36.705047453 +0530
++++ nfs-utils-1.3.0/support/export/hostname.c 2015-12-08 15:25:46.614047453 +0530
+@@ -179,11 +179,11 @@
+ case 0:
+ return ai;
+ case EAI_SYSTEM:
+- xlog(D_GENERAL, "%s: failed to resolve %s: (%d) %m",
++ xlog(L_WARNING, "%s: failed to resolve %s: (%d) %m",
+ __func__, hostname, errno);
+ break;
+ default:
+- xlog(D_GENERAL, "%s: failed to resolve %s: %s",
++ xlog(L_WARNING, "%s: failed to resolve %s: %s",
+ __func__, hostname, gai_strerror(error));
+ break;
+ }
+diff -up nfs-utils-1.3.0/support/nfs/client.c.orig nfs-utils-1.3.0/support/nfs/client.c
+--- nfs-utils-1.3.0/support/export/client.c.orig 2015-12-08 17:08:45.469047453 +0530
++++ nfs-utils-1.3.0/support/export/client.c 2015-12-08 17:09:01.159047453 +0530
+@@ -277,7 +277,7 @@
+ if (htype == MCL_FQDN && !canonical) {
+ ai = host_addrinfo(hname);
+ if (!ai) {
+- xlog(L_ERROR, "Failed to resolve %s", hname);
++ xlog(L_WARNING, "Failed to resolve %s", hname);
+ goto out;
+ }
+ hname = ai->ai_canonname;
[-- Attachment #2: nfs-utils-1.3.0-set-errno.patch --]
[-- Type: text/x-patch, Size: 1165 bytes --]
diff -up nfs-utils-1.3.0/support/nfs/hostname.c.orig nfs-utils-1.3.0/support/nfs/hostname.c
--- nfs-utils-1.3.0/support/export/hostname.c.orig 2015-12-08 15:24:36.705047453 +0530
+++ nfs-utils-1.3.0/support/export/hostname.c 2015-12-08 15:25:46.614047453 +0530
@@ -179,11 +179,11 @@
case 0:
return ai;
case EAI_SYSTEM:
- xlog(D_GENERAL, "%s: failed to resolve %s: (%d) %m",
+ xlog(L_WARNING, "%s: failed to resolve %s: (%d) %m",
__func__, hostname, errno);
break;
default:
- xlog(D_GENERAL, "%s: failed to resolve %s: %s",
+ xlog(L_WARNING, "%s: failed to resolve %s: %s",
__func__, hostname, gai_strerror(error));
break;
}
diff -up nfs-utils-1.3.0/support/nfs/client.c.orig nfs-utils-1.3.0/support/nfs/client.c
--- nfs-utils-1.3.0/support/export/client.c.orig 2015-12-08 17:08:45.469047453 +0530
+++ nfs-utils-1.3.0/support/export/client.c 2015-12-08 17:09:01.159047453 +0530
@@ -277,7 +277,7 @@
if (htype == MCL_FQDN && !canonical) {
ai = host_addrinfo(hname);
if (!ai) {
- xlog(L_ERROR, "Failed to resolve %s", hname);
+ xlog(L_WARNING, "Failed to resolve %s", hname);
goto out;
}
hname = ai->ai_canonname;
next prev parent reply other threads:[~2015-12-22 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1449635027-10764-1-git-send-email-rkothiya@redhat.com>
2015-12-09 4:29 ` [nfs-utils PATCH] Set right error after getaddrinfo fails bz 1287468 Rinku Kothiya
2015-12-21 4:41 ` Rinku Kothiya
2015-12-22 9:09 ` Rinku Kothiya [this message]
2016-01-16 21:59 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56791344.9050900@redhat.com \
--to=rkothiya@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=moagrawa@redhat.com \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox