From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <linux-nfs@vger.kernel.org>, <Trond.Myklebust@primarydata.com>,
<bfields@fieldses.org>
Subject: Re: [PATCH v2 3/3] NFS: Add COPY nfs operation
Date: Mon, 4 Jan 2016 15:05:42 -0500 [thread overview]
Message-ID: <568AD096.1010305@Netapp.com> (raw)
In-Reply-To: <20151220155321.GC18236@infradead.org>
On 12/20/2015 10:53 AM, Christoph Hellwig wrote:
>> + if (res.write_res.committed != NFS_FILE_SYNC) {
>> + status = nfs42_proc_commit(dst, pos_dst, res.write_res.count);
>> + if (status)
>> + return status;
>> + }
>
> Do we really expect data to be stabe on disk after a copy_file_range?
> Seems like the page cache variant doesn't guarantee that, and it would
> also be different from all other I/O syscalls.
It doesn't have to be, I just couldn't figure out how to mark the range as "needs commit" for the next time somebody runs fsync().
Anna
>
> Either way we will probably need to document the assumptions in the man
> page.
>
next prev parent reply other threads:[~2016-01-04 20:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-18 21:05 [PATCH v2 0/3] NFSv4.2: Add support for the COPY operation Anna Schumaker
2015-12-18 21:05 ` [PATCH v2 1/3] NFSD: Don't pass filehandle to nfs4_preprocess_stateid_op() Anna Schumaker
2015-12-20 15:45 ` Christoph Hellwig
2016-01-04 19:01 ` Anna Schumaker
2015-12-18 21:05 ` [PATCH v2 2/3] NFSD: Implement the COPY call Anna Schumaker
2015-12-20 15:50 ` Christoph Hellwig
2016-01-04 19:39 ` Anna Schumaker
2015-12-18 21:05 ` [PATCH v2 3/3] NFS: Add COPY nfs operation Anna Schumaker
2015-12-20 15:53 ` Christoph Hellwig
2016-01-04 20:05 ` Anna Schumaker [this message]
2015-12-18 21:05 ` [RFC v2 4/3] vfs_copy_range() test program Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568AD096.1010305@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=Trond.Myklebust@primarydata.com \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).