From: Steve Dickson <SteveD@redhat.com>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
Benjamin Coddington <bcodding@redhat.com>
Subject: Re: [PATCH] nfsstat: show client rpc information correctly
Date: Sat, 16 Jan 2016 17:00:28 -0500 [thread overview]
Message-ID: <569ABD7C.1000709@RedHat.com> (raw)
In-Reply-To: <567BE110.3070406@gmail.com>
On 12/24/2015 07:12 AM, Kinglong Mee wrote:
> There are 59 client rpc procedures, not 60.
>
> The order of rpc name must be the same as define of
> NFSPROC4_CLNT_xx in include/linux/nfs4.h,
> not nfs4_procedures in nfs4xdr.c.
>
> Drop duplicate rpc name "getdevlist".
>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Committed! Thanks!
steved.
> ---
> utils/nfsstat/nfsstat.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/utils/nfsstat/nfsstat.c b/utils/nfsstat/nfsstat.c
> index b67f0aa..8376347 100644
> --- a/utils/nfsstat/nfsstat.c
> +++ b/utils/nfsstat/nfsstat.c
> @@ -31,7 +31,7 @@ enum {
> SRVPROC3_SZ = 22,
> CLTPROC3_SZ = 22,
> SRVPROC4_SZ = 2,
> - CLTPROC4_SZ = 60,
> + CLTPROC4_SZ = 59,
> SRVPROC4OPS_SZ = 71,
> };
>
> @@ -135,11 +135,10 @@ static const char * nfscltproc4name[CLTPROC4_SZ] = {
> "sequence",
> "get_lease_time",
> "reclaim_comp",
> - "getdevinfo",
> "layoutget",
> + "getdevinfo",
> "layoutcommit",
> "layoutreturn",
> - "getdevlist",
> "secinfo_no",
> "test_stateid",
> "free_stateid",
>
prev parent reply other threads:[~2016-01-16 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 12:12 [PATCH] nfsstat: show client rpc information correctly Kinglong Mee
2015-12-28 18:35 ` Benjamin Coddington
2016-01-16 22:00 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569ABD7C.1000709@RedHat.com \
--to=steved@redhat.com \
--cc=bcodding@redhat.com \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox