From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: Trond Myklebust <trond.myklebust@primarydata.com>,
Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: miklos@szeredi.hu, linux-unionfs@vger.kernel.org,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 3/3] nfs: Store and use inode in nfs_open_context
Date: Wed, 2 Mar 2016 08:27:23 -0600 [thread overview]
Message-ID: <56D6F84B.5040301@suse.de> (raw)
In-Reply-To: <CAHQdGtRu2nd54+tKQLPp2tvf1MpKw4-X8ESqx-8W4_zAov7hFA@mail.gmail.com>
On 03/01/2016 02:46 PM, Trond Myklebust wrote:
> On Tue, Mar 1, 2016 at 1:12 PM, Goldwyn Rodrigues <rgoldwyn@suse.de> wrote:
>>
>> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>>
>> NFS translates the inode from the dentry and uses sb from the dentry
>> parameters. However, using NFS in conjunction with overlayfs, the inodes
>> associated with dentries may be associated with overlayfs as opposed
>> to NFS. So, store inode in nfs_open_context and use d_select_inode()
>> to translate dentry to inode.
>
> I don't see how this helps. The dentry and dentry->d_sb that are
> associated with the open context need to be NFS namespace objects,
> otherwise all sorts of things, ranging from inode lookup to NFSv4
> state recovery are going to break.
>
dentry evaluations and inode lookups are done by overlayfs, with the
help of NFS. NFS becomes a subset of overlayfs. However, you are right.
state recovery will break with this patch.
Which makes me wonder: Shouldn't nfs_open_context (or any open context)
be with respect to an inode as opposed to a dentry?
--
Goldwyn
next prev parent reply other threads:[~2016-03-02 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 18:12 [PATCH 0/3] Fix overlayfs with NFS as lowerdir Goldwyn Rodrigues
2016-03-01 18:12 ` [PATCH 1/3] ovl: Add d_select_inode to reval dentry operations Goldwyn Rodrigues
2016-03-01 18:12 ` [PATCH 2/3] vfs: Add d_select_inode for overlayfs translation Goldwyn Rodrigues
2016-03-01 18:12 ` [PATCH 3/3] nfs: Store and use inode in nfs_open_context Goldwyn Rodrigues
2016-03-01 20:46 ` Trond Myklebust
2016-03-02 14:27 ` Goldwyn Rodrigues [this message]
2016-03-02 14:31 ` Trond Myklebust
2016-03-02 14:38 ` Trond Myklebust
2016-03-02 14:43 ` Miklos Szeredi
2016-03-02 15:57 ` Goldwyn Rodrigues
2016-03-03 8:16 ` Miklos Szeredi
2016-03-04 10:17 ` Miklos Szeredi
2016-03-04 13:41 ` Trond Myklebust
2016-03-04 14:52 ` Goldwyn Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D6F84B.5040301@suse.de \
--to=rgoldwyn@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).