Re: [PATCH v5 6/6] NFSD: Ignore vfs_getattr() failure in nfsd_file_get_dio_attrs()

[Chuck Lever <cel@kernel.org>]

On 10/3/25 3:13 AM, Christoph Hellwig wrote:
> On Mon, Sep 29, 2025 at 11:56:46AM -0400, Chuck Lever wrote:
>> From: Chuck Lever <chuck.lever@oracle.com>
>>
>> A vfs_getattr() failure is rare but not totally impossible.
>>
>> There's no recovery logic in that case; nfsd_do_file_acquire()'s
>> caller will fail but the wonky nfsd_file is left in the file cache.
>>
>> It doesn't seem necessary for nfsd_file_do_acquire() to fail
>> outright if it successfully opened the file but some problem
>> prevented the collection of the dio alignment parameters.
> 
> The only remotely likely case for this is a file system shutdown.
> There's no real way it could fail but I/O later on will work.
> 
> I think just failing serves everyone here much better than try to
> keep going.

Got it.

IMO then more recovery logic is needed in do_file_acquire. We can't then
just leave the moribund nfsd_file in the filecache unless there is some
guarantee that it will not be leaked.


>> Fixes: bc70aaeba7df ("NFSD: filecache: add STATX_DIOALIGN and STATX_DIO_READ_ALIGN support")
> 
> Same comment about fixes being first/separate as for the previous
> patch.
> 


-- 
Chuck Lever