From: Steve Dickson <SteveD@redhat.com>
To: Scott Mayhew <smayhew@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH] exportfs: replace one xlog(D_GENERAL) in host_canonname()
Date: Mon, 2 May 2016 11:58:33 -0400 [thread overview]
Message-ID: <57277929.7030405@RedHat.com> (raw)
In-Reply-To: <1461936366-26852-1-git-send-email-smayhew@redhat.com>
On 04/29/2016 09:26 AM, Scott Mayhew wrote:
> If we fall back to using the numeric host then we shouldn't call
> xlog with D_GENERAL. That can cause 'exportfs -u' to exit with a 1
> if, for example, you have exports using ip addresses that can't be
> resolved to hostnames. Use D_PARSE instead.
>
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Committed...
steved.
> ---
> support/export/hostname.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/export/hostname.c b/support/export/hostname.c
> index 94e98a5..5c4c824 100644
> --- a/support/export/hostname.c
> +++ b/support/export/hostname.c
> @@ -230,7 +230,7 @@ host_canonname(const struct sockaddr *sap)
> default:
> (void)getnameinfo(sap, salen, buf, (socklen_t)sizeof(buf),
> NULL, 0, NI_NUMERICHOST);
> - xlog(D_GENERAL, "%s: failed to resolve %s: %s",
> + xlog(D_PARSE, "%s: failed to resolve %s: %s",
> __func__, buf, gai_strerror(error));
> return NULL;
> }
> -- 2.4.11
>
prev parent reply other threads:[~2016-05-02 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 13:26 [nfs-utils PATCH] exportfs: replace one xlog(D_GENERAL) in host_canonname() Scott Mayhew
2016-05-02 15:58 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57277929.7030405@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).