* [nfs-utils PATCH] exportfs: replace one xlog(D_GENERAL) in host_canonname()
@ 2016-04-29 13:26 Scott Mayhew
2016-05-02 15:58 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: Scott Mayhew @ 2016-04-29 13:26 UTC (permalink / raw)
To: steved; +Cc: linux-nfs
If we fall back to using the numeric host then we shouldn't call
xlog with D_GENERAL. That can cause 'exportfs -u' to exit with a 1
if, for example, you have exports using ip addresses that can't be
resolved to hostnames. Use D_PARSE instead.
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
support/export/hostname.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/support/export/hostname.c b/support/export/hostname.c
index 94e98a5..5c4c824 100644
--- a/support/export/hostname.c
+++ b/support/export/hostname.c
@@ -230,7 +230,7 @@ host_canonname(const struct sockaddr *sap)
default:
(void)getnameinfo(sap, salen, buf, (socklen_t)sizeof(buf),
NULL, 0, NI_NUMERICHOST);
- xlog(D_GENERAL, "%s: failed to resolve %s: %s",
+ xlog(D_PARSE, "%s: failed to resolve %s: %s",
__func__, buf, gai_strerror(error));
return NULL;
}
--
2.4.11
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [nfs-utils PATCH] exportfs: replace one xlog(D_GENERAL) in host_canonname()
2016-04-29 13:26 [nfs-utils PATCH] exportfs: replace one xlog(D_GENERAL) in host_canonname() Scott Mayhew
@ 2016-05-02 15:58 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2016-05-02 15:58 UTC (permalink / raw)
To: Scott Mayhew; +Cc: linux-nfs
On 04/29/2016 09:26 AM, Scott Mayhew wrote:
> If we fall back to using the numeric host then we shouldn't call
> xlog with D_GENERAL. That can cause 'exportfs -u' to exit with a 1
> if, for example, you have exports using ip addresses that can't be
> resolved to hostnames. Use D_PARSE instead.
>
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Committed...
steved.
> ---
> support/export/hostname.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/export/hostname.c b/support/export/hostname.c
> index 94e98a5..5c4c824 100644
> --- a/support/export/hostname.c
> +++ b/support/export/hostname.c
> @@ -230,7 +230,7 @@ host_canonname(const struct sockaddr *sap)
> default:
> (void)getnameinfo(sap, salen, buf, (socklen_t)sizeof(buf),
> NULL, 0, NI_NUMERICHOST);
> - xlog(D_GENERAL, "%s: failed to resolve %s: %s",
> + xlog(D_PARSE, "%s: failed to resolve %s: %s",
> __func__, buf, gai_strerror(error));
> return NULL;
> }
> -- 2.4.11
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-02 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-29 13:26 [nfs-utils PATCH] exportfs: replace one xlog(D_GENERAL) in host_canonname() Scott Mayhew
2016-05-02 15:58 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).