From: Freeman Zhang <zhezhang@redhat.com>
To: Steve Dickson <steved@redhat.com>,
Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] mount.nfs: added usage output when no arguemnts are given
Date: Wed, 8 Jun 2016 18:52:25 +0800 [thread overview]
Message-ID: <5757F8E9.7080705@redhat.com> (raw)
In-Reply-To: <1465324504-8018-1-git-send-email-steved@redhat.com>
On 06/08/2016 02:35 AM, Steve Dickson wrote:
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
> utils/mount/mount_libmount.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/utils/mount/mount_libmount.c b/utils/mount/mount_libmount.c
> index fa46d54..1f01f7f 100644
> --- a/utils/mount/mount_libmount.c
> +++ b/utils/mount/mount_libmount.c
> @@ -208,6 +208,7 @@ static int umount_main(struct libmnt_context *cxt, int argc, char **argv)
>
> if (!spec || (*spec != '/' && strchr(spec,':') == NULL)) {
> nfs_error(_("%s: no mount point provided"), progname);
> + umount_usage();
> return EX_USAGE;
> }
>
> @@ -329,6 +330,7 @@ static int mount_main(struct libmnt_context *cxt, int argc, char **argv)
>
> if (!mount_point) {
> nfs_error(_("%s: no mount point provided"), progname);
> + mount_usage();
> goto err;
> }
> if (!spec) {
Reasonable. Ack.
Acked-by: Freeman Zhang <zhezhang@redhat.com>
next prev parent reply other threads:[~2016-06-08 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 18:35 [PATCH] mount.nfs: added usage output when no arguemnts are given Steve Dickson
2016-06-08 10:52 ` Freeman Zhang [this message]
2016-06-08 13:12 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5757F8E9.7080705@redhat.com \
--to=zhezhang@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).